CONFIG_DEBUG_RAM_SETUP and CONFIG_DEBUG_SMBUS are only available if the board / chipset support it. But this involves a long list of 'depends', which you have to remember updating manually. Converted this into HAVE_... properties, which will be inherited automatically if someone copies a chipset to create a new one.
Signed-off-by: Jens Rottmann <[email protected]> --- --- src/Kconfig (rev 5739) +++ src/Kconfig (working copy) @@ -509,19 +509,13 @@ If enabled, you will be able to set breakpoints for gdb debugging. See src/arch/i386/lib/c_start.S for details. +config HAVE_DEBUG_RAM_SETUP + def_bool n + config DEBUG_RAM_SETUP bool "Output verbose RAM init debug messages" default n - depends on (NORTHBRIDGE_AMD_AMDFAM10 \ - || NORTHBRIDGE_AMD_AMDK8 \ - || NORTHBRIDGE_VIA_CN700 \ - || NORTHBRIDGE_VIA_CX700 \ - || NORTHBRIDGE_VIA_VX800 \ - || NORTHBRIDGE_INTEL_E7501 \ - || NORTHBRIDGE_INTEL_I440BX \ - || NORTHBRIDGE_INTEL_I82810 \ - || NORTHBRIDGE_INTEL_I82830 \ - || NORTHBRIDGE_INTEL_I945) + depends on HAVE_DEBUG_RAM_SETUP help This option enables additional RAM init related debug messages. It is recommended to enable this when debugging issues on your @@ -538,16 +532,13 @@ help If unsure, say N. +config HAVE_DEBUG_SMBUS + def_bool n + config DEBUG_SMBUS bool "Output verbose SMBus debug messages" default n - depends on (SOUTHBRIDGE_VIA_VT8237R \ - || NORTHBRIDGE_VIA_VX800 \ - || NORTHBRIDGE_VIA_CX700 \ - || NORTHBRIDGE_AMD_AMDK8 \ - || NORTHBRIDGE_AMD_AMDFAM10 \ - || BOARD_LIPPERT_SPACERUNNER_LX \ - || SOUTHBRIDGE_VIA_VT8231) + depends on HAVE_DEBUG_SMBUS help This option enables additional SMBus (and SPD) debug messages. --- src/mainboard/lippert/spacerunner-lx/Kconfig (rev 5739) +++ src/mainboard/lippert/spacerunner-lx/Kconfig (working copy) @@ -5,6 +5,7 @@ select NORTHBRIDGE_AMD_LX select SOUTHBRIDGE_AMD_CS5536 select SUPERIO_ITE_IT8712F + select HAVE_DEBUG_SMBUS select HAVE_PIRQ_TABLE select PIRQ_ROUTE select UDELAY_TSC --- src/northbridge/amd/amdfam10/Kconfig (rev 5739) +++ src/northbridge/amd/amdfam10/Kconfig (working copy) @@ -19,6 +19,8 @@ config NORTHBRIDGE_AMD_AMDFAM10 bool + select HAVE_DEBUG_RAM_SETUP + select HAVE_DEBUG_SMBUS select HAVE_HIGH_TABLES select HYPERTRANSPORT_PLUGIN_SUPPORT select NORTHBRIDGE_AMD_AMDFAM10_ROOT_COMPLEX --- src/northbridge/amd/amdk8/Kconfig (rev 5739) +++ src/northbridge/amd/amdk8/Kconfig (working copy) @@ -19,6 +19,8 @@ config NORTHBRIDGE_AMD_AMDK8 bool + select HAVE_DEBUG_RAM_SETUP + select HAVE_DEBUG_SMBUS select HAVE_HIGH_TABLES select HYPERTRANSPORT_PLUGIN_SUPPORT --- src/northbridge/intel/e7501/Kconfig (rev 5739) +++ src/northbridge/intel/e7501/Kconfig (working copy) @@ -1,4 +1,5 @@ config NORTHBRIDGE_INTEL_E7501 bool + select HAVE_DEBUG_RAM_SETUP select HAVE_HIGH_TABLES --- src/northbridge/intel/i440bx/Kconfig (rev 5739) +++ src/northbridge/intel/i440bx/Kconfig (working copy) @@ -19,6 +19,7 @@ config NORTHBRIDGE_INTEL_I440BX bool + select HAVE_DEBUG_RAM_SETUP select HAVE_HIGH_TABLES config SDRAMPWR_4DIMM --- src/northbridge/intel/i82810/Kconfig (rev 5739) +++ src/northbridge/intel/i82810/Kconfig (working copy) @@ -19,6 +19,7 @@ config NORTHBRIDGE_INTEL_I82810 bool + select HAVE_DEBUG_RAM_SETUP select HAVE_HIGH_TABLES choice --- src/northbridge/intel/i82830/Kconfig (rev 5739) +++ src/northbridge/intel/i82830/Kconfig (working copy) @@ -1,5 +1,6 @@ config NORTHBRIDGE_INTEL_I82830 bool + select HAVE_DEBUG_RAM_SETUP select HAVE_HIGH_TABLES choice --- src/northbridge/intel/i945/Kconfig (rev 5739) +++ src/northbridge/intel/i945/Kconfig (working copy) @@ -19,6 +19,7 @@ config NORTHBRIDGE_INTEL_I945 bool + select HAVE_DEBUG_RAM_SETUP select HAVE_HIGH_TABLES config FALLBACK_VGA_BIOS_ID --- src/northbridge/via/cn700/Kconfig (rev 5739) +++ src/northbridge/via/cn700/Kconfig (working copy) @@ -1,5 +1,6 @@ config NORTHBRIDGE_VIA_CN700 bool + select HAVE_DEBUG_RAM_SETUP select HAVE_HIGH_TABLES config FALLBACK_SIZE --- src/northbridge/via/cx700/Kconfig (rev 5739) +++ src/northbridge/via/cx700/Kconfig (working copy) @@ -1,5 +1,7 @@ config NORTHBRIDGE_VIA_CX700 bool + select HAVE_DEBUG_RAM_SETUP + select HAVE_DEBUG_SMBUS select HAVE_HIGH_TABLES select HAVE_HARD_RESET select IOAPIC --- src/northbridge/via/vx800/Kconfig (rev 5739) +++ src/northbridge/via/vx800/Kconfig (working copy) @@ -1,5 +1,7 @@ config NORTHBRIDGE_VIA_VX800 bool + select HAVE_DEBUG_RAM_SETUP + select HAVE_DEBUG_SMBUS config FALLBACK_SIZE int --- src/southbridge/via/vt8231/Kconfig (rev 5739) +++ src/southbridge/via/vt8231/Kconfig (working copy) @@ -19,4 +19,4 @@ config SOUTHBRIDGE_VIA_VT8231 bool - + select HAVE_DEBUG_SMBUS --- src/southbridge/via/vt8237r/Kconfig (rev 5739) +++ src/southbridge/via/vt8237r/Kconfig (working copy) @@ -19,6 +19,7 @@ config SOUTHBRIDGE_VIA_VT8237R bool + select HAVE_DEBUG_SMBUS select IOAPIC config EPIA_VT8237R_INIT _ -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
