On Sun, Sep 05, 2010 at 08:26:41PM +0200, Peter Stuge wrote: > Kevin O'Connor wrote: > > This patch enhances cbfstool so that it can support "cbfstool ROM > > add-lzma FILE NAME" calls. > > It has slightly different semantics than plain add. I think an option > to enable compression would be nicer, so that there's just one > generic add command.
There are three add commands right now: add, add-payload, add-stage. The cbfstool code can't easily handle per-command options. So, doing something like "cbfstool ROM add -c lzma FILE NAME" wont be easy. I can refactor the code so that "add" and "add-lzma" share the same code. Another possibility would be to add getopt to cbfstool and move compression selection for all add commands to it. For example, something like "cbfstool -c lzma ROM add-payload FILE NAME". However, that would require changing the build to use the new form everywhere. -Kevin -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
