Marc Jones wrote:
> IEI Kino mainoard support based on Mahogany Fam10.
> svn copy amd/mahogany iei/kino-780am2-fam10; then apply the patch.
>
> Signed-off-by: Marc Jones <[email protected]>
> +++ coreboot/src/mainboard/iei/kino-780am2-fam10/mainboard.c 2010-09-10
> 10:14:37.000000000 -0600
..
> +/* FIXME - Need to find GPIO for PCIE slot.
> + * Kino uses GPIO ? as PCIe slot reset, GPIO? as GFX slot reset. We need to
> * pull it up before training the slot.
> ***/
> void set_pcie_dereset()
> {
..
> + /* No PCIE slots.*/
> }
>
> void set_pcie_reset()
> {
..
> + /* No PCIE slots.*/
> }
Uh? Is there or is there not a PCIe slot?
> -static void mahogany_enable(device_t dev)
> +static void kino_enable(device_t dev)
> {
> - printk(BIOS_INFO, "Mainboard MAHOGANY Enable. dev=0x%p\n", dev);
> + printk(BIOS_INFO, "Mainboard Kino Enable. dev=0x%p\n", dev);
>
> #if (CONFIG_GFXUMA == 1)
> msr_t msr, msr2;
> @@ -166,6 +121,6 @@
> }
>
> struct chip_operations mainboard_ops = {
> - CHIP_NAME("AMD MAHOGANY Mainboard")
> - .enable_dev = mahogany_enable,
> + CHIP_NAME("IEI Kino-780AM2 Mainboard")
> + .enable_dev = kino_enable,
> };
Could the mainboard enable function reuse the CHIP_NAME somehow, or
maybe both should just use CONFIG_MAINBOARD_PART_NUMBER ?
Acked-by: Peter Stuge <[email protected]>
--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
