> On Thu, Oct 07, 2010 at 03:55:41PM -0600, Myles Watson wrote: > > Kconfig_if.diff : use if instead of depends on to avoid typos > > socket_type.diff : don't define socket_type and dimm_type when they > aren't used > > raminit_sysinfo.diff : get rid of another define > > > > Signed-off-by: Myles Watson <[email protected]> > > Looks good to me. > > Acked-by: Uwe Hermann <[email protected]>
Rev 5920. > > - depends on NORTHBRIDGE_AMD_AMDK8 > > + > > +if K8_REV_F_SUPPORT > > > > config DIMM_DDR2 > > bool > > default n > > - depends on NORTHBRIDGE_AMD_AMDFAM10 > > > > config DIMM_REGISTERED > > bool > > default n > > - depends on NORTHBRIDGE_AMD_AMDFAM10 > > Is this the "prevent typos" you refer to above, i.e., the > variables in amdk8/Kconfig depending on Fam10h? Yes. Too much copy & paste. :( Thanks, Myles -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
