2010/10/10 Sylvain 'ythier' Hitier <sylvain.hit...@gmail.com> > Hello, > > r5929 seems quite mechanical, especially when removing the inclusions of > the > lib/debug.c file. > > I noticed that: > Inclusion is kept for these mainboards: > p2b-d > p2b-ls > whereas removed from all these ones: > p2b > p2b-ds > p2b-f > p3b-f > and > Inclusion is kept for this mainboard: > ga-6bxe > whereas removed from this one: > ga-6bxc > > I feel the mainboards look like quite similar (but I diff'ed only SVN'ed > files > in these dirs). > > However I couldn't find any reason why #include is sometimes kept... > > Hence I suggest the following _untested_ patch. > > Regards, > Sylvain "ythier" Hitier > > ======== > > Remove more inclusions of lib/debug.c after r5929. >
Does your patch survive abuild for each board ? > > Signed-off-by: Sylvain Hitier <sylvain.hit...@gmail.com> > If it does: Acked-by: Idwer Vollering <vid...@gmail.com> > > Index: mainboard/gigabyte/ga-6bxe/romstage.c > =================================================================== > --- mainboard/gigabyte/ga-6bxe/romstage.c (revision 5929) > +++ mainboard/gigabyte/ga-6bxe/romstage.c (working copy) > @@ -28,7 +28,6 @@ > #include <console/console.h> > #include "southbridge/intel/i82371eb/i82371eb.h" > #include "northbridge/intel/i440bx/raminit.h" > -#include "lib/debug.c" > #include "pc80/udelay_io.c" > #include "lib/delay.c" > #include "cpu/x86/bist.h" > Index: mainboard/asus/p2b-ls/romstage.c > =================================================================== > --- mainboard/asus/p2b-ls/romstage.c (revision 5929) > +++ mainboard/asus/p2b-ls/romstage.c (working copy) > @@ -28,7 +28,6 @@ > #include <console/console.h> > #include "southbridge/intel/i82371eb/i82371eb.h" > #include "northbridge/intel/i440bx/raminit.h" > -#include "lib/debug.c" > #include "pc80/udelay_io.c" > #include "lib/delay.c" > #include "cpu/x86/bist.h" > Index: mainboard/asus/p2b-d/romstage.c > =================================================================== > --- mainboard/asus/p2b-d/romstage.c (revision 5929) > +++ mainboard/asus/p2b-d/romstage.c (working copy) > @@ -29,7 +29,6 @@ > #include <console/console.h> > #include "southbridge/intel/i82371eb/i82371eb.h" > #include "northbridge/intel/i440bx/raminit.h" > -#include "lib/debug.c" > #include "pc80/udelay_io.c" > #include "lib/delay.c" > #include "cpu/x86/bist.h" > > > > -- > Free hugs for Free Software Fellows! > Living in a Debian package => http://en.wikipedia.org/wiki/Apt,_Vaucluse >
-- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot