On Wed, Oct 13, 2010 at 1:03 PM, Uwe Hermann <[email protected]> wrote: > On Tue, Oct 12, 2010 at 11:41:24PM -0400, Keith Hui wrote: > >> Attached patch adds support for Katmai Slot 1 CPUs (model_67x). >> abuild-tested. Boot tested on P2B-LS. >> >> Signed-off-by: Keith Hui <[email protected]> > > Thanks, r5950 with some small whitespace changes. > > I also dropped the name.o from Makefile.inc, the functions provided > there are not (yet?) used in model_67x I think. > > Also, you added 671 as CPU ID to model_67x which was not in there yet. > Can you point me to the document where this one is listed, so we can > reference it in a code comment?
There are two references of that CPU ID that I know of. I found a microcode update for a 0x671 CPU from the Intel file. Then I remember looking at Intel's processor finder website and found mentions of it. Now that site has been reorganized as ark.intel.com I can no longer easily confirm which S-spec CPUs will identify as 0x671. It's there for completeness. >> As we already know the L2 patch is a huge chunk of code, so let's >> figure out where best to place that code. It is specific to 63x,65x >> and 67x CPUs. There are some small code path differences between these >> CPU families. I'm trying to minimize duplication; > > Yep. > >> if these code can be >> put in one .c file and be linked from a few other places, that's how >> I'd prefer it. > > Yes, that would be great. > So the question now is where in the tree? This can for example be potentially placed in cpu/intel/slot_1 because only slot 1 CPUs need the setup cpu/intel/model_67x because I'm going to start here first among a few other candidates. Thanks Keith -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
