The name of sblink seems more clear, but for most cases, the name of sblk only appears in K8/Fam10 codes, so it didn't cause much confusions.
A more consistent way to get HT southbridge link in sb700 chipset is to include the <cpu/amd/amdk8_sysconf.h> or <cpu/amd/amdfam10_sysconf.h>, and use global variable sysconf.sblk. For now, fam10 codes set sysconf.sblk during early romstage, but K8 codes didn't. Maybe we should fix K8 coeds to set sysconf.sblk earlyer, and use it in later device drivers. On Mon, Oct 18, 2010 at 6:01 AM, Uwe Hermann <[email protected]> wrote: > On Sun, Oct 17, 2010 at 11:39:46PM +0200, Uwe Hermann wrote: >> - Renamed sblk to sblink (the name of the register bits as per >> BIOS + Kernel Developer's Guide for AMD Athlon 64 & AMD Opteron >> Processors, >> chapter 3.3.8. > > Hm, I noticed that the K8/Fam10h code uses "sblk" as function/variable name > pretty consistently, but I can't seem to find that spelling in any of > the AMD manuals. Should we rename "sblk" to "sblink" in the whole tree? -- Regards, Liu Tao -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
