Hi,
with r6114, no board in trunk uses smp_write_bus directly anymore.
Instead, mptable_write_buses looks up all buses in the device tree and
adds them to the table accordingly.
I propose to hide smp_write_bus, so no new board can reintroduce such code.
==
Make smp_write_bus static (local scope), to prevent new boards from
using it directly again.
Signed-off-by: Patrick Georgi <[email protected]
Index: src/arch/i386/boot/mpspec.c
===================================================================
--- src/arch/i386/boot/mpspec.c (Revision 6113)
+++ src/arch/i386/boot/mpspec.c (Arbeitskopie)
@@ -157,7 +157,7 @@
}
}
-void smp_write_bus(struct mp_config_table *mc,
+static void smp_write_bus(struct mp_config_table *mc,
unsigned char id, const char *bustype)
{
struct mpc_config_bus *mpc;
Index: src/arch/i386/include/arch/smp/mpspec.h
===================================================================
--- src/arch/i386/include/arch/smp/mpspec.h (Revision 6113)
+++ src/arch/i386/include/arch/smp/mpspec.h (Arbeitskopie)
@@ -243,8 +243,6 @@
unsigned char cpuflag, unsigned int cpufeature,
unsigned int featureflag);
void smp_write_processors(struct mp_config_table *mc);
-void smp_write_bus(struct mp_config_table *mc,
- unsigned char id, const char *bustype);
void smp_write_ioapic(struct mp_config_table *mc,
unsigned char id, unsigned char ver,
unsigned long apicaddr);
--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
