* repository service <[email protected]> [101122 17:23]: > Author: uwe > Date: Mon Nov 22 17:23:54 2010 > New Revision: 6116 > URL: https://tracker.coreboot.org/trac/coreboot/changeset/6116 > > Log: > Drop unused ACPI_WRITE_MADT_IOAPIC #define. > > This should probably be C code in some .c file anyway. As a macro I think it belongs in a .h file.
Should we not rather use it than drop it? Sounds kind of useful. We don't really have IOAPICs in our device tree, and using PCI_BASE_ADDRESS_0 sounds wrong. How do we get IOAPICs into the tree? I think the southbridges should add it where appropriate and I think we need a new device type, as we have one for local APICs too. Stefan. > Signed-off-by: Uwe Hermann <[email protected]> > Acked-by: Uwe Hermann <[email protected]> > > Modified: > trunk/src/arch/i386/include/arch/acpi.h > > Modified: trunk/src/arch/i386/include/arch/acpi.h > ============================================================================== > --- trunk/src/arch/i386/include/arch/acpi.h Mon Nov 22 16:57:57 2010 > (r6115) > +++ trunk/src/arch/i386/include/arch/acpi.h Mon Nov 22 17:23:54 2010 > (r6116) > @@ -431,17 +431,6 @@ > /* cpu/intel/speedstep/acpi.c */ > void generate_cpu_entries(void); > > -#define ACPI_WRITE_MADT_IOAPIC(dev,id) \ > -do { \ > - struct resource *res; \ > - res = find_resource(dev, PCI_BASE_ADDRESS_0); \ > - if (!res) break; \ > - current += acpi_create_madt_ioapic( \ > - (acpi_madt_ioapic_t *)current, \ > - id, res->base, gsi_base); \ > - gsi_base += 4; \ > -} while(0); > - > #else // CONFIG_GENERATE_ACPI_TABLES > > #define write_acpi_tables(start) (start) > > -- > coreboot mailing list: [email protected] > http://www.coreboot.org/mailman/listinfo/coreboot > -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
