Uwe Hermann wrote: > Add TINY_BOOTBLOCK support for AMD SB700. > > Factor out the ROM decode enable functionality into bootblock.c and > handle it via the usual TINY_BOOTBLOCK mechanism. > > Use "select TINY_BOOTBLOCK" in the southbridge, not individual boards. > > Signed-off-by: Uwe Hermann <[email protected]>
Acked-by: Peter Stuge <[email protected]> But please: > +/* > + * Enable 1MB (LPC) ROM access at 0xFFF00000 - 0xFFFFFFFF. > + * > + * Hardware should enable LPC ROM by pin straps. This function does not > + * handle the theoretically possible PCI ROM, FWH, or SPI ROM configurations. > + * > + * The SB700 power-on default is to map 256K ROM space. > + * > + * Details: AMD SB700/710/750 BIOS Developer's Guide (BDG), page 14. > + */ > +static void sb700_enable_rom(void) ..make this an unambiguous reference, and I like having the document number as in the old comment. Maybe even a link, but at least doc nr and version. Maybe also section besides the page nr. //Peter -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
