Change the print_conf activation from >=BIOS_ERR to >=BIOS_DEBUG.
Signed-off-by: Nils Jacobs <[email protected]>
Op donderdag 30 december 2010 02:44:12 schreef u:
> On Wed, Dec 29, 2010 at 4:46 PM, Nils <[email protected]> wrote:
> > Op woensdag 29 december 2010 21:44:08 schreef u:
> >> On Wed, Dec 29, 2010 at 12:04 PM, Nils <[email protected]> wrote:
> >> > Add a MSR printing function to northbridge.c like in the Geode LX
> >> > code.
> >>
> >> It's surprising to have it included
> >>
> >> +#if CONFIG_DEFAULT_CONSOLE_LOGLEVEL >= BIOS_ERR
> >>
> >> but then have all the print statements be BIOS_DEBUG.
> >>
> >> Thanks,
> >> Myles
> >
> > You are right, i copied it from Geode LX and didn't notice it.
> > Should i make a patch to change it on GX2 and LX to BIOS_DEBUG ?
>
> It's up to you. I think there could be a better way to handle it, but
> there are many ways to change it.
>
> Thanks,
> Myles
This patch is boot tested on my Wyse S50.
If one of the professionals comes up with a better patch i will be happy to
test it. :)
Thanks, Nils.
Index: src/northbridge/amd/gx2/northbridge.c
===================================================================
--- src/northbridge/amd/gx2/northbridge.c (revision 6221)
+++ src/northbridge/amd/gx2/northbridge.c (working copy)
@@ -42,7 +42,7 @@
*/
void print_conf(void)
{
-#if CONFIG_DEFAULT_CONSOLE_LOGLEVEL >= BIOS_ERR
+#if CONFIG_DEFAULT_CONSOLE_LOGLEVEL >= BIOS_DEBUG
int i;
unsigned long iol;
msr_t msr;
@@ -183,7 +183,7 @@
iol = inl(GPIO_MAPPER_X);
printk(BIOS_DEBUG, "IOR 0x%08X is now 0x%08lX\n", GPIO_IO_BASE + GPIO_MAPPER_X,
iol);
-#endif /* CONFIG_DEFAULT_CONSOLE_LOGLEVEL >= BIOS_ERR */
+#endif /* CONFIG_DEFAULT_CONSOLE_LOGLEVEL >= BIOS_DEBUG */
}
/* todo: add a resource record. We don't do this here because this may be called when
Index: src/northbridge/amd/lx/northbridge.c
===================================================================
--- src/northbridge/amd/lx/northbridge.c (revision 6221)
+++ src/northbridge/amd/lx/northbridge.c (working copy)
@@ -118,7 +118,7 @@
*/
void print_conf(void)
{
-#if CONFIG_DEFAULT_CONSOLE_LOGLEVEL >= BIOS_ERR
+#if CONFIG_DEFAULT_CONSOLE_LOGLEVEL >= BIOS_DEBUG
int i;
unsigned long iol;
msr_t msr;
@@ -259,7 +259,7 @@
iol = inl(GPIO_MAPPER_X);
printk(BIOS_DEBUG, "IOR 0x%08X is now 0x%08lX\n", GPIO_IO_BASE + GPIO_MAPPER_X,
iol);
-#endif //CONFIG_DEFAULT_CONSOLE_LOGLEVEL >= BIOS_ERR
+#endif /* CONFIG_DEFAULT_CONSOLE_LOGLEVEL >= BIOS_DEBUG */
}
/* todo: add a resource record. We don't do this here because this may be called when
--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
