* Marc Bertens <[email protected]> [110107 12:11]: > >-----Original Message----- > >From: Stefan Reinauer <[email protected]> > >To: [email protected] > >Subject: Re: [coreboot] [commit] r6247 - trunk/src/mainboard/nokia/ip530 > >Date: Fri, 7 Jan 2011 01:21:26 +0100 > > > >This is not particularly beautiful. Is there any advantage of using the > >irq hack rather than putting this as code into some mainboard specific > >init function? > > The irq hack is still needed and has nothing to do with the stuff in the > devicetree.cb > The advantage of putting it all here, to me readability, and its now > compatible with the > vendor BIOS. So i don't understand why you want to drop some things from here. I'm not suggesting to remove it, but rather to put it into mainboard.c as code.
> >> @@ -40,10 +40,55 @@ > >> + device pnp 3f0.8 on # AUX I/O > >> + irq 0x24 = 0x84 # OSC > >> + > >> + irq 0xB2 = 0x0C # Soft power status 1 > >> + irq 0xB3 = 0x05 # Soft power status 2 > >> + irq 0xC0 = 0x03 # IRQ MUX control > >> + > >> + irq 0xC8 = 0x10 # GP50 = (I/O) output = Flashrom > >> enable > >> + irq 0xCA = 0x09 # GP52 = IRQ8 (output) > >> + irq 0xCB = 0x01 # GP53 = nROMCS (output) > >------ 8< ------- > >> + irq 0xCC = 0x11 # GP54 = (I/O) input > >------ >8 ------- > >> + irq 0xF9 = 0x00 # read/write GP5x lines (0x1C) > >> + > >> + irq 0xD0 = 0x08 # GP60 = IRQ1 > >> + irq 0xD1 = 0x08 # GP61 = IRQ3 > >> + irq 0xD2 = 0x08 # GP62 = IRQ4 > > > >------ 8< ------- > >> + irq 0xD3 = 0x11 # GP63 = (I/O) input = JP901 on board > >> + irq 0xD4 = 0x11 # GP64 = (I/O) input > >> + irq 0xD5 = 0x11 # GP65 = (I/O) input > >------ >8 ------- > > > >I don't think writing to GP inputs makes a lot of sense. Guess this > >could/should be dropped. > > The inputs can be used for reading at the moment the status of the two > onboard jumpers. Yes, but writing to them as happens through the irq xx = yy statements is not good. Please consider removing all lines between my scissors in the original mail: ------ 8< ------- ------ >8 ------- Stefan -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
