I think we need a report table to record the status of every combination
of processor + DIMMs. More test need to be done on the supported boards.
We can not change PresetmaxFreq to 800 until it is ok for each case.
Before that, I am afraid we need to keep in mind that there is a limit
here.


Zheng

> -----Original Message-----
> From: Stefan Reinauer [mailto:[email protected]]
> Sent: Thursday, January 20, 2011 2:36 AM
> To: Bao, Zheng
> Cc: [email protected]
> Subject: Re: [coreboot] [patch] AMDMCT DDR3 fix Dual rank + high mem
> frequency.
> 
> * Bao, Zheng <[email protected]> [110119 10:37]:
> > For Cx, each ChipSel need to be sent MR command.
> > After this patch, tilapia can run in higher memory frequency.
> > To test the high frequency, dont forget to change the freq limit in
> > mcti_d.c:
> >  static void mctGet_MaxLoadFreq(struct DCTStatStruc *pDCTstat)
> >  {
> >      pDCTstat->PresetmaxFreq = 800;
> >  }
> 
> Is it safe to add this to the repository? I'm worried that people will
> forget over time.
> 
> > Signed-off-by: Zheng Bao <[email protected]>
> 
> Acked-by: Stefan Reinauer <[email protected]>
> 
> > Index: src/northbridge/amd/amdmct/mct_ddr3/mctsdi.c
> > ===================================================================
> > --- src/northbridge/amd/amdmct/mct_ddr3/mctsdi.c    (revision 6275)
> > +++ src/northbridge/amd/amdmct/mct_ddr3/mctsdi.c    (working copy)
> > @@ -306,7 +306,7 @@
> >                             if (!(pDCTstat->Status & (1 <<
> > SB_Registered)))
> >                                     break; /* For UDIMM, only send
> > MR commands once per channel */
> >             }
> > -           if (pDCTstat->LogicalCPUID & (AMD_DR_Cx/* | AMD_RB_C0
> > */)) /* We dont support RB_C0 now. need to be added and tested. */
> > +           if (pDCTstat->LogicalCPUID & (AMD_DR_Bx/* | AMD_RB_C0
> > */)) /* We dont support RB_C0 now. need to be added and tested. */
> >                     if (!(pDCTstat->Status & (1 << SB_Registered)))
> >                             MrsChipSel ++;
> >     }
> 
> 
> > --
> > coreboot mailing list: [email protected]
> > http://www.coreboot.org/mailman/listinfo/coreboot
> 



-- 
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to