* Georgi, Patrick <[email protected]> [110128 08:22]: > Am Donnerstag, den 27.01.2011, 18:16 -0800 schrieb Stefan Reinauer: > > +#if defined(__ROMCC__) > > +#define printk(BIOS_DEBUG, fmt, arg...) do {} while(0) > > +#else > romcc doesn't support variadic macros. This only "works" because no > chipset that uses romcc supports USB debug. > Given the age of romcc-chipsets I think it's safe to assume that they > support serial console, so how about we make usbdebug a CAR-only feature > (ie. drop this #define)? You are right. The rest of the code has some CAR assumptions, too, and the code complexity would probably make romcc explode anyways. So for now, I dropped the ROMCC specific stuff, including the changes I made to src/include/console/console.h
> Otherwise the patch is > Acked-by: Patrick Georgi <[email protected]> Thanks. r6315 -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
