Georgi, Patrick wrote:
> Question is, if we should drop these Kconfig options entirely and let
> the user handle these entries in the board's Makefile.inc?

Sometimes the files come from chipset though.


> Signed-off-by: Patrick Georgi <[email protected]>

With the fix below:

Acked-by: Peter Stuge <[email protected]>


> +++ b/src/arch/x86/Makefile.inc
> @@ -117,6 +96,18 @@ endif
>       @printf "    CBFSPRINT  $(subst $(obj)/,,$(@))\n\n"
>       $(CBFSTOOL) $@ print
>  
> +cbfs-files-$(CONFIG_VGA_BIOS) += pci$(call 
> strip_quotes,$(CONFIG_VGA_BIOS_ID)).rom
> +pci$(CONFIG_VGA_BIOS_ID)-file := $(call strip_quotes,$(CONFIG_VGA_BIOS_FILE))
> +pci$(CONFIG_VGA_BIOS_ID)-type := optionrom

These last two need .rom as well, right?


//Peter

Attachment: pgpCGtYlrillb.pgp
Description: PGP signature

-- 
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to