Hi,

There were a couple of patches flying around the last days, (which, I
have to admit, are of specific interest to me), which seem to have
died-off. I've never seen such an (IPDS) Instant Patch Death Syndrome
in other projects I contributed to, so perhaps my email was not being
delivered.

See patches for message/sign-off.

Alex

Attachment: add_pci_id.patch
Description: Binary data

Fix an infinite loop in pnp_get_ioresource(), which freezes coreboot if
a rare condition arises.

Based on findings by Alexandru Gagniuc <[email protected]>

Signed-off-by: Stefan Reinauer <[email protected]>

Acked-by: Alexandru Gagniuc <[email protected]>

diff --git a/src/devices/pnp_device.c b/src/devices/pnp_device.c
index b2bca03..4a6d266 100644
--- a/src/devices/pnp_device.c
+++ b/src/devices/pnp_device.c
@@ -170,6 +170,12 @@ static void pnp_get_ioresource(device_t dev, u8 index, struct io_info *info)
 	struct resource *resource;
 	unsigned moving, gran, step;
 
+	if (!info->mask) {
+		printk(BIOS_ERR, "ERROR: device %s index %d has no mask.\n",
+				dev_path(dev), index);
+		return;
+	}
+
 	resource = new_resource(dev, index);
 
 	/* Initilize the resource. */
-- 
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to