>> Index: src/superio/winbond/w83627ehg/superio.c
>> ===================================================================
>> --- src/superio/winbond/w83627ehg/superio.c (revision 6323)
>> +++ src/superio/winbond/w83627ehg/superio.c (working copy)
>> @@ -189,7 +189,7 @@
>> { &ops, W83627EHG_HWM, PNP_IO0 | PNP_IRQ0, {0x07fe, 0}, },
>>
>> { &ops, W83627EHG_GAME, PNP_IO0, {0x07ff, 0}, },
>> - { &ops, W83627EHG_MIDI, PNP_IO1 | PNP_IRQ0, {0x07fe, 4}, },
>> + { &ops, W83627EHG_MIDI, PNP_IO0 | PNP_IRQ0, {0x07fe, 4}, },
>> { &ops, W83627EHG_GPIO1, },
>> { &ops, W83627EHG_GPIO2, },
>> { &ops, W83627EHG_GPIO3, },
>
> I don't think this is the right fix.
> The datasheet says the MIDI BAR is at 62h, 63h.
> Hence the mask needs to be in the second position, not the first.
>
> Maybe try something like:
> { &ops, W83627EHG_MIDI, PNP_IO1 | PNP_IRQ0, {0, 0}, {0x07fe, 4}, }
>
> Jonathan Kollasch
Thanks. Find attached the updated micropatch.
Alex
Fixes a problem with the W8327EHG driver, where the midi device
could get initialised with no mask.
Based on input from Jonathan Kollasch <[email protected]>
Signed-off-by: Alexandru Gagniuc <[email protected]>
Index: src/superio/winbond/w83627ehg/superio.c
===================================================================
--- src/superio/winbond/w83627ehg/superio.c (revision 6323)
+++ src/superio/winbond/w83627ehg/superio.c (working copy)
@@ -189,7 +189,7 @@
{ &ops, W83627EHG_HWM, PNP_IO0 | PNP_IRQ0, {0x07fe, 0}, },
{ &ops, W83627EHG_GAME, PNP_IO0, {0x07ff, 0}, },
- { &ops, W83627EHG_MIDI, PNP_IO1 | PNP_IRQ0, {0x07fe, 4}, },
+ { &ops, W83627EHG_MIDI, PNP_IO1 | PNP_IRQ0, {0, 0}, {0x07fe, 4}, },
{ &ops, W83627EHG_GPIO1, },
{ &ops, W83627EHG_GPIO2, },
{ &ops, W83627EHG_GPIO3, },
--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
