Stefan Reinauer wrote:
>> +++ trunk/src/superio/smsc/lpc47n227/superio.c       Sat Feb 19 15:51:31 
>> 2011        (r6373)
..
>> -    lpc47n227_pnp_set_enable(dev, (dev->enabled) ? 1 : 0);
>> +    lpc47n227_pnp_set_enable(dev, !!dev->enabled);
>
> How's this different?

This particular file did not have a functional change, but others
did.


> I like the ?: notion more than the :: notion.

I also like !! and I guess this file was changed to make this code
look the same everywhere.

Maybe it could even be moved to a common function.


//Peter

-- 
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to