Dear Scott and coreboot folks,
Am Mittwoch, den 18.05.2011, 01:40 -0500 schrieb Scott Duplichan: […] looking at the change > Index: src/mainboard/amd/bimini_fam10/acpi_tables.c > =================================================================== > --- src/mainboard/amd/bimini_fam10/acpi_tables.c (revision 6599) > +++ src/mainboard/amd/bimini_fam10/acpi_tables.c (working copy) > @@ -127,6 +127,31 @@ > acpi_write_rsdp(rsdp, rsdt, NULL); > acpi_write_rsdt(rsdt); > > + /* DSDT */ > + current = ( current + 0x07) & -0x08; > + printk(BIOS_DEBUG, "ACPI: * DSDT at %lx\n", current); > + dsdt = (acpi_header_t *)current; // it will used by fadt > + memcpy(dsdt, &AmlCode, sizeof(acpi_header_t)); > + current += dsdt->length; > + memcpy(dsdt, &AmlCode, dsdt->length); > + printk(BIOS_DEBUG, "ACPI: * DSDT @ %p Length > %x\n",dsdt,dsdt->length); > + > + /* FACS */ // it needs 64 bit alignment > + current = ( current + 0x07) & -0x08; > + printk(BIOS_DEBUG, "ACPI: * FACS at %lx\n", current); > + facs = (acpi_facs_t *) current; // it will be used by fadt > + current += sizeof(acpi_facs_t); > + acpi_create_facs(facs); > + > + /* FADT */ > + current = ( current + 0x07) & -0x08; > + printk(BIOS_DEBUG, "ACPI: * FADT at %lx\n", current); > + fadt = (acpi_fadt_t *) current; > + current += sizeof(acpi_fadt_t); > + > + acpi_create_fadt(fadt, facs, dsdt); > + acpi_add_table(rsdp, fadt); […] the contents seems to very similar. Besides some comments even identical. Can `acpi_tables.c` be shared between certain families or even all new boards? If yes, maybe that could be put on a todo list. Thanks, Paul
signature.asc
Description: This is a digitally signed message part
-- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
