Your recent changes make the error messages go away.
However, I noticed another error message about PS2 controller:
[ 1.543494] i8042 kbd 00:02: unable to assign resources
[ 1.584667] i8042 kbd: probe of 00:02 failed with error -16
[ 1.625694] i8042 aux 00:03: [irq 12]
[ 1.626460] i8042 aux 00:03: activated
[ 1.666536] PNP: PS/2 Controller [PNP0f13:PS2M] at 0x0,0x0 irq 12
[ 1.706908] PNP: PS/2 controller has invalid data port 0x0; using
default 0x60
[ 1.747678] PNP: PS/2 controller has invalid command port 0x0; using
default 0x64
[ 1.788888] PNP: PS/2 controller doesn't have KBD irq; using default 1
[ 2.081400] serio: i8042 KBD port at 0x60,0x64 irq 1
[ 2.122528] mice: PS/2 mouse device common for all mice
I also saw something that looks like bug in your code (my proposed
changes below). However, it doesn't cure the above error messages, so I
may be wrong ...
@@ -1148,7 +1142,7 @@ Scope (\_SB)
Or (Local1, Local0, Local0)
ShiftLeft(Local2, 8, Local2)
- Or (Local1, Local0, Local0)
+ Or (Local3, Local2, Local2)
CreateWordField (CRS, IO0._MIN, IMIN)
Store (Local0, IMIN)
@@ -1192,7 +1186,7 @@ Scope (\_SB)
ShiftRight(Local1, 8, Local1)
Divide(IOA1, 256, Local2, Local3)
- ShiftRight(Local1, 8, Local1)
+ ShiftRight(Local3, 8, Local3)
FindSetLeftBit (IRQL, Local4)
Subtract (Local4, 0x01, Local4)
@@ -1256,7 +1250,7 @@ Scope (\_SB)
Or (Local1, Local0, Local0)
ShiftLeft(Local2, 8, Local2)
- Or (Local1, Local0, Local0)
+ Or (Local3, Local2, Local2)
CreateWordField (CRS, IO0._MIN, IMIN)
Store (Local0, IMIN)
On 10/19/2011 02:28 AM, Christoph Grenz ([email protected])
wrote:
Christoph Grenz ([email protected]) just uploaded a new patch set to
gerrit, which you can find at http://review.coreboot.org/296
-gerrit
commit 6a22d1c7e41a6ee47d32572afebc035c114390a3
Author: Christoph Grenz<[email protected]>
Date: Wed Oct 19 02:24:23 2011 +0200
w83627hf: correct typo in ASL include, correct indexed registers and
remove unneccesary _PR0 defs
Correct a typo in devtree.asl which causes AML processors to fail executing
the DSDT with AE_NO_MEMORY or (in case of acpiexec) Divide By Zero.
Also removes an superfluous item in the register IndexField and removes
unneccessary _PR0 definitions which could confuse AML processors.
Change-Id: I02cb9ce4e8f2101cfff8cec4abba7e070fd66364
Signed-off-by: Christoph Grenz<[email protected]>
---
src/superio/winbond/w83627hf/devtree.asl | 11 ++---------
1 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/src/superio/winbond/w83627hf/devtree.asl
b/src/superio/winbond/w83627hf/devtree.asl
index fa78845..cbc132d 100644
--- a/src/superio/winbond/w83627hf/devtree.asl
+++ b/src/superio/winbond/w83627hf/devtree.asl
@@ -74,7 +74,7 @@ Scope (\_SB)
ADDR, 8,
DATA, 8
}
- IndexField (CREG, DATA, ByteAcc, NoLock, Preserve)
+ IndexField (ADDR, DATA, ByteAcc, NoLock, Preserve)
{
Offset (0x02),
RST, 1, /* Soft reset */
@@ -84,7 +84,6 @@ Scope (\_SB)
Offset (0x20),
DID, 8, /* Device ID */
DREV, 8, /* Device Revision */
- POWC, 8,
FDPW, 1, /* FDC Power Down */
, 2,
PRPW, 1, /* PRT Power Down */
@@ -258,7 +257,6 @@ Scope (\_SB)
Store (One, FDPW)
EXCM ()
}
- Name (_PR0, Package () { ^^ })
Method (_DIS)
{
@@ -470,7 +468,6 @@ Scope (\_SB)
Store (One, PRPW)
EXCM ()
}
- Name (_PR0, Package () { ^^ })
Method (_DIS) {
ENCM ()
@@ -650,7 +647,6 @@ Scope (\_SB)
Store (One, UAPW)
EXCM ()
}
- Name (_PR0, Package () { ^^ })
Method (_DIS)
{
@@ -783,7 +779,6 @@ Scope (\_SB)
Store (One, UBPW)
EXCM ()
}
- Name (_PR0, Package () { ^^ })
Method (_DIS)
{
@@ -916,7 +911,6 @@ Scope (\_SB)
Store (One, UBPW)
EXCM ()
}
- Name (_PR0, Package () { ^^ })
Method (_DIS)
{
@@ -1479,7 +1473,6 @@ Scope (\_SB)
Store (One, HWPW)
EXCM ()
}
- Name (_PR0, Package () { ^^ })
Method (_CRS)
{
@@ -1511,4 +1504,4 @@ Scope (\_SB)
}
#endif
}
-}
\ No newline at end of file
+}
--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
