the following patch was just integrated into master:
commit 73127b54c338ddddff3e7c91df65788c750d79bf
Author: Vadim Bendebury <[email protected]>
Date: Sat Nov 5 02:07:01 2011 +0000
Fix coreboot makefiles not to produce half baked output.
It looks like the cbfstool utility generates the output file even when
it fails to generate it properly. This causes make, if started second
time in a row, after cbfstool failure, to continue beyond the point of
failure (as the corrupted output file is present in the output tree,
the second make invocation presumes that it is valid, as it is newer
than the dependencies).
The output file should be created only when successful, in an atomic
operation. There could be other places in the make system which
require a similar fix, this needs to be investigated further.
Change-Id: I7c17f033ee5937eb712b1a594122430cee5c9146
Signed-off-by: Vadim Bendebury <[email protected]>
Build-Tested: build bot (Jenkins) at Fri Mar 30 04:38:39 2012, giving +1
Reviewed-By: Stefan Reinauer <[email protected]> at Fri Mar 30
01:24:36 2012, giving +2
See http://review.coreboot.org/750 for details.
-gerrit
--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
