Vikram Narayanan ([email protected]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/878
-gerrit commit 65aff4f8d15fec36023e22a25a1f48b331a9353e Author: Vikram Narayanan <[email protected]> Date: Sat Apr 7 16:28:26 2012 +0530 hexdump: fix compiler warning Fixed "warning: format not a string literal and no format arguments" Change-Id: If752a37f268c90f782c6e831e5477ea804e48026 Signed-off-by: Vikram Narayanan <[email protected]> --- util/nvramtool/hexdump.c | 18 +++++++++--------- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/util/nvramtool/hexdump.c b/util/nvramtool/hexdump.c index 4d13963..e6d9faf 100644 --- a/util/nvramtool/hexdump.c +++ b/util/nvramtool/hexdump.c @@ -83,10 +83,10 @@ void hexdump(const void *mem, int bytes, uint64_t addrprint_start, bytes_left >= format->bytes_per_line; bytes_left -= format->bytes_per_line) { /* print start address for current line */ - fprintf(outfile, format->indent); + fprintf(outfile, "%s", format->indent); addrprint(outfile, addrprint_start + index, format->addrprint_width); - fprintf(outfile, format->sep1); + fprintf(outfile, "%s", format->sep1); /* display the bytes in hex */ for (i = 0;;) { @@ -95,11 +95,11 @@ void hexdump(const void *mem, int bytes, uint64_t addrprint_start, if (++i >= format->bytes_per_line) break; - fprintf(outfile, format->sep2); + fprintf(outfile, "%s", format->sep2); } index -= format->bytes_per_line; - fprintf(outfile, format->sep3); + fprintf(outfile, "%s", format->sep3); /* display the bytes as characters */ for (i = 0; i < format->bytes_per_line; i++, index++) @@ -112,14 +112,14 @@ void hexdump(const void *mem, int bytes, uint64_t addrprint_start, return; /* print start address for last line */ - fprintf(outfile, format->indent); + fprintf(outfile, "%s", format->indent); addrprint(outfile, addrprint_start + index, format->addrprint_width); - fprintf(outfile, format->sep1); + fprintf(outfile, "%s", format->sep1); /* display bytes for last line in hex */ for (i = 0; i < bytes_left; i++) { fprintf(outfile, "%02x", p[index++]); - fprintf(outfile, format->sep2); + fprintf(outfile, "%s", format->sep2); } index -= bytes_left; @@ -131,10 +131,10 @@ void hexdump(const void *mem, int bytes, uint64_t addrprint_start, if (++i >= format->bytes_per_line) break; - fprintf(outfile, format->sep2); + fprintf(outfile, "%s", format->sep2); } - fprintf(outfile, format->sep3); + fprintf(outfile, "%s", format->sep3); /* display bytes for last line as characters */ for (i = 0; i < bytes_left; i++) -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
