Zheng Bao ([email protected]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1401
-gerrit commit f80c3d9eff0d31d02cf8f541a55b3576dc89aedc Author: zbao <[email protected]> Date: Fri Aug 3 14:56:49 2012 +0800 Trivial: Change <tab># to <tab>@# in Makefile command My editor highlights the <tab># as syntax error. I think it is because every line starting with a <tab> is seen as a command. But # is not a makefile accepted command, is it? I found in {top}/Makefile.inc there are some <tab>@#. So I think every makefile should sync with that format. Change-Id: Ib86165df4fefff3007693f9b8077a5a0a00bb6d3 Signed-off-by: Zheng Bao <[email protected]> Signed-off-by: zbao <[email protected]> --- Makefile.inc | 2 +- documentation/Makefile | 2 +- payloads/external/FILO/Makefile.inc | 4 ++-- payloads/external/SeaBIOS/Makefile.inc | 4 ++-- src/southbridge/amd/Makefile.inc | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Makefile.inc b/Makefile.inc index ca1e066..4259cad 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -95,7 +95,7 @@ $(obj)/$(1).ramstage.o: src/$(1).asl $(obj)/config.h cd $$(dir $$@); $(IASL) -p $$(notdir $$@) -tc $$(notdir $$(basename $$@)).asl mv $$(basename $$@).hex $$(basename $$@).c $(CC) $$(CFLAGS) $$(if $$(subst dsdt,,$$(basename $$(notdir $(1)))), -DAmlCode=AmlCode_$$(basename $$(notdir $(1)))) -c -o $$@ $$(basename $$@).c - # keep %.o: %.c rule from catching the temporary .c file after a make clean + @# keep %.o: %.c rule from catching the temporary .c file after a make clean mv $$(basename $$@).c $$(basename $$@).hex endef diff --git a/documentation/Makefile b/documentation/Makefile index 84ac0b5..1a19828 100644 --- a/documentation/Makefile +++ b/documentation/Makefile @@ -32,7 +32,7 @@ else ifneq ($(strip $(CONVERT)),) endif LinuxBIOS-AMD64.toc: $(FIGS) LinuxBIOS-AMD64.tex - # 2 times to make sure we have a current toc. + @# 2 times to make sure we have a current toc. $(PDFLATEX) LinuxBIOS-AMD64.tex $(PDFLATEX) LinuxBIOS-AMD64.tex diff --git a/payloads/external/FILO/Makefile.inc b/payloads/external/FILO/Makefile.inc index 311b3c8..cce075b 100644 --- a/payloads/external/FILO/Makefile.inc +++ b/payloads/external/FILO/Makefile.inc @@ -27,8 +27,8 @@ config: libpayload echo "CONFIG_LZMA=y" >> filo/.config echo "CONFIG_FLASH_FLOPPY=y" >> filo/.config echo "CONFIG_VGAHOOKS=y" >> filo/.config - # This shows how to force a previously set .config option *off* - #echo "# CONFIG_SMBIOS is not set" >> filo/.config + @# This shows how to force a previously set .config option *off* + @#echo "# CONFIG_SMBIOS is not set" >> filo/.config filo: config echo " MAKE FILO $(NAME-y)" diff --git a/payloads/external/SeaBIOS/Makefile.inc b/payloads/external/SeaBIOS/Makefile.inc index e0f03b1..8e47576 100644 --- a/payloads/external/SeaBIOS/Makefile.inc +++ b/payloads/external/SeaBIOS/Makefile.inc @@ -29,8 +29,8 @@ config: checkout echo "CONFIG_LZMA=y" >> $(OUT)/seabios/.config echo "CONFIG_FLASH_FLOPPY=y" >> $(OUT)/seabios/.config echo "CONFIG_VGAHOOKS=y" >> $(OUT)/seabios/.config - # This shows how to force a previously set .config option *off* - #echo "# CONFIG_SMBIOS is not set" >> $(OUT)/seabios/.config + @# This shows how to force a previously set .config option *off* + @#echo "# CONFIG_SMBIOS is not set" >> $(OUT)/seabios/.config build: config echo " MAKE SeaBIOS $(TAG-y)" diff --git a/src/southbridge/amd/Makefile.inc b/src/southbridge/amd/Makefile.inc index 9709715..733a9bc 100644 --- a/src/southbridge/amd/Makefile.inc +++ b/src/southbridge/amd/Makefile.inc @@ -21,7 +21,7 @@ ifeq ($(CONFIG_CPU_AMD_AGESA), y) $(obj)/s3.rom: echo " S3 NVRAM 0xffff0000 (S3 storage area)" - # force C locale, so cygwin awk doesn't try to interpret the 0xff below as UTF-8 (or worse) + @ # force C locale, so cygwin awk doesn't try to interpret the 0xff below as UTF-8 (or worse) LC_ALL=C awk 'BEGIN {for (i=0; i<32768; i++) {printf "%c", 255}}' > [email protected] mv [email protected] $@ -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
