Patrick Georgi ([email protected]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2185
-gerrit commit 896218058fcccce5e74c5867f2c1660df190c207 Author: Patrick Georgi <[email protected]> Date: Wed Jan 23 13:45:23 2013 +0100 ioapic: Factor out counting code to `ioapic_interrupt_count` No need to keep duplicate variants of counting ioapic interrupts. Change-Id: I512860297309c46e05cc5379bf61479878817b1e Signed-off-by: Patrick Georgi <[email protected]> --- src/arch/x86/lib/ioapic.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/src/arch/x86/lib/ioapic.c b/src/arch/x86/lib/ioapic.c index e05d80c..fc5e307 100644 --- a/src/arch/x86/lib/ioapic.c +++ b/src/arch/x86/lib/ioapic.c @@ -34,15 +34,10 @@ static void io_apic_write(u32 ioapic_base, u32 reg, u32 value) write32(ioapic_base + 0x10, value); } -void clear_ioapic(u32 ioapic_base) +static int ioapic_interrupt_count(int ioapic_base) { - u32 low, high; - u32 i, ioapic_interrupts; - - printk(BIOS_DEBUG, "IOAPIC: Clearing IOAPIC at 0x%08x\n", ioapic_base); - /* Read the available number of interrupts. */ - ioapic_interrupts = (io_apic_read(ioapic_base, 0x01) >> 16) & 0xff; + int ioapic_interrupts = (io_apic_read(ioapic_base, 0x01) >> 16) & 0xff; if (ioapic_interrupts == 0xff) ioapic_interrupts = 23; ioapic_interrupts += 1; /* Bits 23-16 specify the maximum redirection @@ -50,6 +45,18 @@ void clear_ioapic(u32 ioapic_base) minus 1. */ printk(BIOS_DEBUG, "IOAPIC: %d interrupts\n", ioapic_interrupts); + return ioapic_interrupts; +} + +void clear_ioapic(u32 ioapic_base) +{ + u32 low, high; + u32 i, ioapic_interrupts; + + printk(BIOS_DEBUG, "IOAPIC: Clearing IOAPIC at 0x%08x\n", ioapic_base); + + ioapic_interrupts = ioapic_interrupt_count(ioapic_base); + low = DISABLED; high = NONE; @@ -86,14 +93,7 @@ void setup_ioapic(u32 ioapic_base, u8 ioapic_id) (ioapic_id << 24)); } - /* Read the available number of interrupts. */ - ioapic_interrupts = (io_apic_read(ioapic_base, 0x01) >> 16) & 0xff; - if (ioapic_interrupts == 0xff) - ioapic_interrupts = 23; - ioapic_interrupts += 1; /* Bits 23-16 specify the maximum redirection - entry, which is the number of interrupts - minus 1. */ - printk(BIOS_DEBUG, "IOAPIC: %d interrupts\n", ioapic_interrupts); + ioapic_interrupts = ioapic_interrupt_count(ioapic_base); #if CONFIG_IOAPIC_INTERRUPTS_ON_FSB /* -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
