David Hendricks wrote: > David Hendricks ([email protected]) just uploaded a new patch set to > gerrit, which you can find at http://review.coreboot.org/2297 > > -gerrit > > commit b115b35c581af7892739afd7c4aaf2250e260f51 > Author: Hung-Te Lin <[email protected]> > Date: Wed Feb 6 17:48:20 2013 +0800 > > armv7: Clean up: remove deprecated SPL. > > "SPL" from U-Boot is deprecated by bootblock in coreboot/arm, so we don't > need > it anymore.
.. > diff --git a/src/cpu/samsung/exynos5250/power.c > b/src/cpu/samsung/exynos5250/power.c > index 7c61655..60003c4 100644 > --- a/src/cpu/samsung/exynos5250/power.c > +++ b/src/cpu/samsung/exynos5250/power.c > @@ -23,12 +23,12 @@ > */ > > #include <common.h> > +#include <arch/hlt.h> > #include <arch/io.h> > #include <console/console.h> > #include <cpu/samsung/exynos5250/cpu.h> > #include <cpu/samsung/exynos5250/power.h> > #include <cpu/samsung/exynos5250/sysreg.h> > -#include <cpu/samsung/exynos5-common/spl.h> > #include <drivers/maxim/max77686/max77686.h> > > #include "device/i2c.h" > @@ -62,7 +62,7 @@ void power_shutdown(void) > > clrbits_le32(&power->ps_hold_ctrl, POWER_PS_HOLD_CONTROL_DATA_HIGH); > > - hang(); > + hlt(); > } > > void power_enable_dp_phy(void) Most of the above hunk has nothing to do with this commit. It should of course have been part of the hang() removal commit but failing that at the very least put in a separate commit. Please do really thorough self-review before pushing, this kind of super simple problems are pretty easy to spot. Thanks. //Peter -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
