Martin Roth ([email protected]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2349
-gerrit commit 53b42ad1978dad9048222dec4e7609dea1b4f898 Author: Martin Roth <[email protected]> Date: Sun Feb 10 14:26:20 2013 -0700 AMD SB900: fix warnings Add a prototype to a .h file Remove an unused file (GppHp.c) from the build by deleting it from the makefile. I left the file since this is vendorcode. This is the code for PCIe hotplug. Inside GppHp.c, make functions not called from outside static. This obviously isn't important since the file isn't used, but for the sake of the cleanup I thought I'd go ahead with it... This was tested with the torpedo build. This fixes these warnings: src/vendorcode/amd/cimx/sb900/Dispatcher.c: In function 'LocateImage': src/vendorcode/amd/cimx/sb900/Dispatcher.c:193:38: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] src/vendorcode/amd/cimx/sb900/Usb.c:740:1: warning: no previous prototype for 'XhciA12Fix' [-Wmissing-prototypes] src/vendorcode/amd/cimx/sb900/GppHp.c:65:1: warning: no previous prototype for 'sbGppHotPlugSmiProcess' [-Wmissing-prototypes] src/vendorcode/amd/cimx/sb900/GppHp.c: In function 'sbGppHotPlugSmiProcess': src/vendorcode/amd/cimx/sb900/GppHp.c:76:5: warning: implicit declaration of function 'SbStall' [-Wimplicit-function-declaration] src/vendorcode/amd/cimx/sb900/GppHp.c: At top level: src/vendorcode/amd/cimx/sb900/GppHp.c:101:1: warning: no previous prototype for 'sbGppHotUnplugSmiProcess' [-Wmissing-prototypes] src/vendorcode/amd/cimx/sb900/GppHp.c:134:1: warning: no previous prototype for 'sbGppHotplugSmiCallback' [-Wmissing-prototypes] src/vendorcode/amd/cimx/sb900/GppHp.c: In function 'sbGppHotplugSmiCallback': src/vendorcode/amd/cimx/sb900/GppHp.c:158:5: warning: implicit declaration of function 'outPort80' [-Wimplicit-function-declaration] Change-Id: I5a1a20eeb81e1f4d59e3e3192f081e11d8506f56 Signed-off-by: Martin Roth <[email protected]> --- src/vendorcode/amd/cimx/sb900/Dispatcher.c | 2 +- src/vendorcode/amd/cimx/sb900/GppHp.c | 5 +++-- src/vendorcode/amd/cimx/sb900/Makefile.inc | 1 - src/vendorcode/amd/cimx/sb900/SbSubFun.h | 1 + 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/vendorcode/amd/cimx/sb900/Dispatcher.c b/src/vendorcode/amd/cimx/sb900/Dispatcher.c index 152ffc2..583f929 100644 --- a/src/vendorcode/amd/cimx/sb900/Dispatcher.c +++ b/src/vendorcode/amd/cimx/sb900/Dispatcher.c @@ -190,7 +190,7 @@ LocateImage ( #ifdef x64 12346789 #else - Result = VerifyImage (Signature, (VOID*) (__int64)ImagePtr); + Result = VerifyImage (Signature, (VOID*) (intptr_t) ImagePtr); #endif if ( Result != NULL ) { return Result; diff --git a/src/vendorcode/amd/cimx/sb900/GppHp.c b/src/vendorcode/amd/cimx/sb900/GppHp.c index 4975b8a..24f5ec8 100644 --- a/src/vendorcode/amd/cimx/sb900/GppHp.c +++ b/src/vendorcode/amd/cimx/sb900/GppHp.c @@ -43,6 +43,7 @@ */ #include "SbPlatform.h" #include "cbtypes.h" +#include "AmdSbLib.h" // // Declaration of external functions @@ -61,7 +62,7 @@ UINT8 GppPortPollingLtssm (IN AMDSBCFG* pConfig, IN UINT8 ActivePorts, IN BOOLEA * @param[in] HpPort The hot plug port number. * */ -VOID +static VOID sbGppHotPlugSmiProcess ( IN AMDSBCFG* pConfig, IN UINT32 HpPort @@ -97,7 +98,7 @@ sbGppHotPlugSmiProcess ( * @param[in] HpPort The hot plug port number. * */ -VOID +static VOID sbGppHotUnplugSmiProcess ( IN AMDSBCFG* pConfig, IN UINT32 HpPort diff --git a/src/vendorcode/amd/cimx/sb900/Makefile.inc b/src/vendorcode/amd/cimx/sb900/Makefile.inc index e29bdc9..75b499e 100755 --- a/src/vendorcode/amd/cimx/sb900/Makefile.inc +++ b/src/vendorcode/amd/cimx/sb900/Makefile.inc @@ -76,7 +76,6 @@ ramstage-y += Usb.c #ramstage-y += Legacy.c #ramstage-y += SbModInf.c ramstage-y += Debug.c -ramstage-y += GppHp.c ramstage-y += Hwm.c CIMX_CFLAGS = diff --git a/src/vendorcode/amd/cimx/sb900/SbSubFun.h b/src/vendorcode/amd/cimx/sb900/SbSubFun.h index 3349c1b..69563ef 100644 --- a/src/vendorcode/amd/cimx/sb900/SbSubFun.h +++ b/src/vendorcode/amd/cimx/sb900/SbSubFun.h @@ -605,3 +605,4 @@ void TurnOffCG2 (OUT void); */ void BackUpCG2 (OUT void); +void XhciA12Fix (OUT void); \ No newline at end of file -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
