Patrick Georgi ([email protected]) just uploaded a new patch set to 
gerrit, which you can find at http://review.coreboot.org/2733

-gerrit

commit 7684c5704fae4af6606beda9b37bc0b8b48a6344
Author: Patrick Georgi <[email protected]>
Date:   Fri Mar 15 14:11:37 2013 +0100

    i945: Replace some magic values by defined names
    
    Cleanup.
    
    Change-Id: I4e4c617dcd3ede81a0abbe16f9916562d24fa8ce
    Signed-off-by: Patrick Georgi <[email protected]>
---
 src/northbridge/intel/i945/raminit.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/northbridge/intel/i945/raminit.c 
b/src/northbridge/intel/i945/raminit.c
index 758a97e..bbd6528 100644
--- a/src/northbridge/intel/i945/raminit.c
+++ b/src/northbridge/intel/i945/raminit.c
@@ -295,18 +295,18 @@ static void sdram_detect_errors(struct sys_info *sysinfo)
        pci_write_config8(PCI_DEV(0, 0x1f, 0), 0xa2, reg8);
 
        /* clear self refresh status if check is disabled or not a resume */
-       if (!CONFIG_CHECK_SLFRCS_ON_RESUME || sysinfo->boot_path != 2) {
-               MCHBAR8(0xf14) |= 3;
+       if (!CONFIG_CHECK_SLFRCS_ON_RESUME || sysinfo->boot_path != 
BOOT_PATH_RESUME) {
+               MCHBAR8(SLFRCS) |= 3;
        } else {
                /* Validate self refresh config */
                if (((sysinfo->dimm[0] != SYSINFO_DIMM_NOT_POPULATED) ||
                     (sysinfo->dimm[1] != SYSINFO_DIMM_NOT_POPULATED)) &&
-                   !(MCHBAR8(0xf14) & (1<<0))) {
+                   !(MCHBAR8(SLFRCS) & (1<<0))) {
                        do_reset = 1;
                }
                if (((sysinfo->dimm[2] != SYSINFO_DIMM_NOT_POPULATED) ||
                     (sysinfo->dimm[3] != SYSINFO_DIMM_NOT_POPULATED)) &&
-                   !(MCHBAR8(0xf14) & (1<<1))) {
+                   !(MCHBAR8(SLFRCS) & (1<<1))) {
                        do_reset = 1;
                }
        }

-- 
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to