David Hendricks ([email protected]) just uploaded a new patch set to 
gerrit, which you can find at http://review.coreboot.org/2862

-gerrit

commit dc6f2a701fae3291ae22043a3219bcd4aec6a793
Author: David Hendricks <[email protected]>
Date:   Tue Mar 19 17:25:24 2013 -0700

    armv7: allow build_lb_mem() to clean up memory ranges
    
    Allow build_lb_mem() to clean up the memory ranges again now that
    regions are allocated and we don't die.
    
    This also removes an obsolete FIXME comment in build_lb_mem().
    
    Change-Id: I8bda11915b1f1fe39683c20e8827ddbf53949dc7
    Signed-off-by: David Hendricks <[email protected]>
---
 src/arch/armv7/boot/coreboot_table.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/arch/armv7/boot/coreboot_table.c 
b/src/arch/armv7/boot/coreboot_table.c
index 47aad36..e2e732d 100644
--- a/src/arch/armv7/boot/coreboot_table.c
+++ b/src/arch/armv7/boot/coreboot_table.c
@@ -547,13 +547,11 @@ static struct lb_memory *build_lb_mem(struct lb_header 
*head)
        mem = lb_memory(head);
        mem_ranges = mem;
 
-       /* FIXME: implement this */
        /* Build the raw table of memory */
        search_global_resources(
                IORESOURCE_MEM | IORESOURCE_CACHEABLE, IORESOURCE_MEM | 
IORESOURCE_CACHEABLE,
                build_lb_mem_range, mem);
-       /* FIXME: things die in cleanup_memory_ranges(), skip for now */
-//     lb_cleanup_memory_ranges(mem);
+       lb_cleanup_memory_ranges(mem);
        return mem;
 }
 

-- 
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to