David Hendricks wrote: > There is CONFIG_CPU_DMP_VORTEX86EX which might be useful.
I disagree. > Maybe Andrew can try something like this: .. > +ifeq ($(CONFIG_CPU_DMP_VORTEX86EX),y) > +# Old memmove implementation from Linux always use REP MOVSL > +# which is much faster on some CPUs. > +ramstage-y += memmove_old.c > +romstage-y += memmove_old.c > +smm-y += memmove_old.c The file is called memmove_old.c and not memmove_DMP_VORTEX86EX.c, so if Kconfig should be involved the controlling variable really needs to be one with a meaningful name, and it would get selected (only) by the Vortex86 CPU Kconfig files. I would prefer a patch for our memmove, unless there is a strong reason not to use REP also in the general case. //Peter -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
