Hey Paul, one last thought here. Is it possible that some of these platforms support PS2 keyboards and some don't? Would that explain why some have Y and some have N?
ron On Sun, Oct 13, 2013 at 12:26 AM, Paul Menzel <[email protected]> wrote: > Paul Menzel ([email protected]) just uploaded a new patch set > to gerrit, which you can find at http://review.coreboot.org/3966 > > -gerrit > > commit 0f2066f68fa406505fd1346ce096801e800da981 > Author: Paul Menzel <[email protected]> > Date: Sun Oct 13 09:15:24 2013 +0200 > > AMD AGESA boards: Kconfig: Do not set `DRIVERS_PS2_KEYBOARD` > > The Kconfig option `DRIVERS_PS2_KEYBOARD`, controlling if the > PS/2 keyboard should be initialized or not, should only be > selected by the user as it depends on if the selected payload > is able to initialize the keyboard or not. > > So remove that option from the mainboard’s Kconfig with the > following commmand. > > $ git grep -l DRIVERS_PS2_KEYBOARD src/mainboard | xargs sed -i > '/DRIVERS_PS2_KEYBOARD/,+3d' > > Change-Id: Iafff465daf522d9bd1127c3098dff093920d4db6 > Signed-off-by: Paul Menzel <[email protected]> > --- > src/mainboard/amd/dinar/Kconfig | 4 ---- > src/mainboard/amd/inagua/Kconfig | 4 ---- > src/mainboard/amd/persimmon/Kconfig | 4 ---- > src/mainboard/amd/south_station/Kconfig | 4 ---- > src/mainboard/amd/torpedo/Kconfig | 4 ---- > src/mainboard/amd/union_station/Kconfig | 4 ---- > src/mainboard/asrock/e350m1/Kconfig | 4 ---- > src/mainboard/lippert/frontrunner-af/Kconfig | 4 ---- > src/mainboard/lippert/toucan-af/Kconfig | 4 ---- > src/mainboard/supermicro/h8qgi/Kconfig | 4 ---- > src/mainboard/supermicro/h8scm/Kconfig | 4 ---- > src/mainboard/tyan/s8226/Kconfig | 4 ---- > 12 files changed, 48 deletions(-) > > diff --git a/src/mainboard/amd/dinar/Kconfig b/src/mainboard/amd/dinar/Kconfig > index 441357b..8441d44 100644 > --- a/src/mainboard/amd/dinar/Kconfig > +++ b/src/mainboard/amd/dinar/Kconfig > @@ -88,10 +88,6 @@ config SIO_PORT > hex > default 0x2e > > -config DRIVERS_PS2_KEYBOARD > - bool > - default y > - > config ONBOARD_VGA_IS_PRIMARY > bool > default y > diff --git a/src/mainboard/amd/inagua/Kconfig > b/src/mainboard/amd/inagua/Kconfig > index cf868fe..5101b19 100644 > --- a/src/mainboard/amd/inagua/Kconfig > +++ b/src/mainboard/amd/inagua/Kconfig > @@ -90,10 +90,6 @@ config SIO_PORT > hex > default 0x2e > > -config DRIVERS_PS2_KEYBOARD > - bool > - default y > - > config ONBOARD_VGA_IS_PRIMARY > bool > default y > diff --git a/src/mainboard/amd/persimmon/Kconfig > b/src/mainboard/amd/persimmon/Kconfig > index 5781a25..02af942 100644 > --- a/src/mainboard/amd/persimmon/Kconfig > +++ b/src/mainboard/amd/persimmon/Kconfig > @@ -111,8 +111,4 @@ config SB800_AHCI_ROM > bool > default n > > -config DRIVERS_PS2_KEYBOARD > - bool > - default n > - > endif # BOARD_AMD_PERSIMMON > diff --git a/src/mainboard/amd/south_station/Kconfig > b/src/mainboard/amd/south_station/Kconfig > index 81d631f..c05295e 100644 > --- a/src/mainboard/amd/south_station/Kconfig > +++ b/src/mainboard/amd/south_station/Kconfig > @@ -105,9 +105,5 @@ config VGA_BIOS_ID > string > default "1002,9806" > > -config DRIVERS_PS2_KEYBOARD > - bool > - default n > - > endif # BOARD_AMD_SOUTHSTATION > > diff --git a/src/mainboard/amd/torpedo/Kconfig > b/src/mainboard/amd/torpedo/Kconfig > index cfcf3cb..a426301 100644 > --- a/src/mainboard/amd/torpedo/Kconfig > +++ b/src/mainboard/amd/torpedo/Kconfig > @@ -150,10 +150,6 @@ config XHC_BIOS_ID > depends on XHC_BIOS > default "1022,7812" > > -config DRIVERS_PS2_KEYBOARD > - bool > - default y > - > config CONSOLE_POST > bool > depends on !NO_POST > diff --git a/src/mainboard/amd/union_station/Kconfig > b/src/mainboard/amd/union_station/Kconfig > index 848fd36..735e84d 100644 > --- a/src/mainboard/amd/union_station/Kconfig > +++ b/src/mainboard/amd/union_station/Kconfig > @@ -104,9 +104,5 @@ config VGA_BIOS_ID > string > default "1002,9802" > > -config DRIVERS_PS2_KEYBOARD > - bool > - default n > - > endif # BOARD_AMD_UNIONSTATION > > diff --git a/src/mainboard/asrock/e350m1/Kconfig > b/src/mainboard/asrock/e350m1/Kconfig > index 026deeb..b905624 100644 > --- a/src/mainboard/asrock/e350m1/Kconfig > +++ b/src/mainboard/asrock/e350m1/Kconfig > @@ -98,9 +98,5 @@ config VGA_BIOS_ID > string > default "1002,9802" > > -config DRIVERS_PS2_KEYBOARD > - bool > - default n > - > endif # BOARD_ASROCK_E350M1 > > diff --git a/src/mainboard/lippert/frontrunner-af/Kconfig > b/src/mainboard/lippert/frontrunner-af/Kconfig > index 945d9cb..903b154 100644 > --- a/src/mainboard/lippert/frontrunner-af/Kconfig > +++ b/src/mainboard/lippert/frontrunner-af/Kconfig > @@ -115,8 +115,4 @@ config SB800_AHCI_ROM > bool > default n > > -config DRIVERS_PS2_KEYBOARD > - bool > - default n > - > endif # BOARD_LIPPERT_FRONTRUNNER_AF > diff --git a/src/mainboard/lippert/toucan-af/Kconfig > b/src/mainboard/lippert/toucan-af/Kconfig > index be016fb..c2d4d73 100644 > --- a/src/mainboard/lippert/toucan-af/Kconfig > +++ b/src/mainboard/lippert/toucan-af/Kconfig > @@ -117,8 +117,4 @@ config SB800_AHCI_ROM > bool > default n > > -config DRIVERS_PS2_KEYBOARD > - bool > - default n > - > endif # BOARD_LIPPERT_TOUCAN_AF > diff --git a/src/mainboard/supermicro/h8qgi/Kconfig > b/src/mainboard/supermicro/h8qgi/Kconfig > index 5ee9a19..f965b58 100644 > --- a/src/mainboard/supermicro/h8qgi/Kconfig > +++ b/src/mainboard/supermicro/h8qgi/Kconfig > @@ -89,10 +89,6 @@ config SIO_PORT > though UARTs are on the NUVOTON BMC, port 0x164E > PS2 keyboard and mouse are on SUPERIO_WINBOND_W83627DHG, port > 0x2E > > -config DRIVERS_PS2_KEYBOARD > - bool > - default y > - > config ONBOARD_VGA_IS_PRIMARY > bool > default y > diff --git a/src/mainboard/supermicro/h8scm/Kconfig > b/src/mainboard/supermicro/h8scm/Kconfig > index a7f40be..969fae1 100644 > --- a/src/mainboard/supermicro/h8scm/Kconfig > +++ b/src/mainboard/supermicro/h8scm/Kconfig > @@ -92,10 +92,6 @@ config SIO_PORT > though UARTs are on the NUVOTON BMC, port 0x164E > PS2 keyboard and mouse are on SUPERIO_WINBOND_W83627DHG, port > 0x2E > > -config DRIVERS_PS2_KEYBOARD > - bool > - default y > - > config ONBOARD_VGA_IS_PRIMARY > bool > default y > diff --git a/src/mainboard/tyan/s8226/Kconfig > b/src/mainboard/tyan/s8226/Kconfig > index 68ce152..ded2620 100644 > --- a/src/mainboard/tyan/s8226/Kconfig > +++ b/src/mainboard/tyan/s8226/Kconfig > @@ -85,10 +85,6 @@ config SIO_PORT > though UARTs are on the NUVOTON BMC, port 0x164E > PS2 keyboard and mouse are on SUPERIO_WINBOND_W83627DHG, port > 0x2E > > -config DRIVERS_PS2_KEYBOARD > - bool > - default y > - > config ONBOARD_VGA_IS_PRIMARY > bool > default y > > -- > coreboot-gerrit mailing list: [email protected] > http://www.coreboot.org/mailman/listinfo/coreboot-gerrit -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
