options are broken for x86 because it is assuming big endian. A quick patch to make it work:

diff --git a/payloads/libpayload/drivers/options.c b/payloads/libpayload/drivers
index 70c2b17..a7a5d82 100644
--- a/payloads/libpayload/drivers/options.c
+++ b/payloads/libpayload/drivers/options.c
@@ -69,7 +69,7 @@ int options_checksum_valid(const struct nvram_accessor *nvram)
                checksum += nvram->read(i);
        }

- checksum_old = ((nvram->read(checksum_location)<<8) | nvram->read(checks + checksum_old = ((nvram->read(checksum_location+1)<<8) | nvram->read(chec

        return (checksum_old == checksum);
 }

Maybe a union and assigning each byte is the correct approach?

Cheers,
Sean


--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to