On Wed, Sep 3, 2014 at 8:46 AM, Vadim Bendebury <[email protected]> wrote:
> Note that the version of gerrit used for chromeos allows editing the > commit message through the web interface, no need to re-upload the > patch, and the scores are kept. > > Not sure if this is available in the coreboot gerrit though. > Yes, it is. I happen to think that is sufficient to accomplish what Paul is asking w.r.t. fixing commit messages. But I also like the idea of keeping scores for trivial rebases and no code change as well. There's no sense in having to wait for somebody to re-approve a patch for such things. > > --vb > > > On Wed, Sep 3, 2014 at 12:39 AM, Paul Menzel > <[email protected]> wrote: > > Dear coreboot folks, > > > > > > on IRC I was told, developers won’t update or fix commit messages as > > long as it means +2 scores are removed. > > > > Luckily Gerrit supports that [2]. > > > > A useful feature on labels is the possibility to automatically > > copy scores forward to new patch sets if it was a trivial rebase > > or if there was no code change (e.g. only the commit message was > > edited). > > > > I propose to enable these two features. > > > > If nobody opposes until next Monday, September 8th, it’d be great if the > > two config parameters below could be set to true. > > > > 1. label.Label-Name.copyAllScoresOnTrivialRebase [3] > > 2. label.Label-Name.copyAllScoresIfNoCodeChange [4] > > > > > > Thanks, > > > > Paul > > > > > > [1] > http://review.coreboot.org/Documentation/intro-project-owner.html#labels > > [2] > http://review.coreboot.org/Documentation/intro-project-owner.html#labels > > [3] > http://review.coreboot.org/Documentation/config-labels.html#label_copyAllScoresOnTrivialRebase > > [4] > http://review.coreboot.org/Documentation/config-labels.html#label_copyAllScoresIfNoCodeChange > > > > -- > > coreboot mailing list: [email protected] > > http://www.coreboot.org/mailman/listinfo/coreboot > > -- > coreboot mailing list: [email protected] > http://www.coreboot.org/mailman/listinfo/coreboot -- David Hendricks (dhendrix) Systems Software Engineer, Google Inc.
-- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
