Hi Mohan, Thanks for your patch.
On Fri, Sep 12, 2014 at 12:50 AM, Mohan <[email protected]> wrote: > On 09/11/14 18:16, Idwer Vollering wrote: >> >> 2014-09-11 9:34 GMT+02:00 Mohan <[email protected]>: >>> >>> Hi, >>> >>> This is a tentative patch for S3 suspend/resume support in MinnowMax >>> Board. >> >> (..) > > ?? > > This patch is more of a requests for comments.. > >> >>> Comments, suggestion, corrections are welcome. >>> I would like to get it added it, can anyone help me ? >> >> Certainly. Have you read this subpage, >> http://www.coreboot.org/Development_Guidelines#Creating_Patches ? It >> will answer most of your questions. >> > > I need to register at http://review.coreboot.org/ and submit my patch using > git, right ? Yes, This page has the setup details: http://www.coreboot.org/Git > > Also need to add a "Signed-off-by:" to my patch. Yes, and gerrit will force you to do that when you do the git push. Stop in #coreboot if you have questions or problems on your first commit. Once it is in gerrit. Regards, Marc > > Thanks, > Mohan > > > -- > coreboot mailing list: [email protected] > http://www.coreboot.org/mailman/listinfo/coreboot -- http://se-eng.com -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
