it's way easier if you push your changes to gerrit marked as a WIP. People can see the code and will likely spot any problems very quickly.
On Fri, Dec 16, 2016 at 12:40 AM Agrain Patrick < [email protected]> wrote: > Hi all, > > I'm trying to add a new superIO chip to the source tree. > The chip is an EXAR XR28V932. > I tried to take example of the existing superIO chips, like the i3100 and > it8716 to compose a correct source tree as following: > [agrain1@frilldlin059 coreboot]$ ls -als ./src/superio/exar/xr28v382/ > total 10 > 1 drwxr-xr-x 2 agrain1 dhs2 512 Dec 16 09:03 . > 1 drwxr-xr-x 3 agrain1 dhs2 512 Dec 15 09:41 .. > 1 -rw-r--r-- 1 agrain1 dhs2 687 Dec 15 09:34 Makefile.inc > 3 -rw-r--r-- 1 agrain1 dhs2 2614 Dec 16 09:03 superio.c > 2 -rw-r--r-- 1 agrain1 dhs2 1287 Dec 15 16:28 xr28v382.h > > I modified the devicetree.cb of my board (based on an Intel Mohon Peak) as > following: > device pci 1f.0 on end # LPC bridge > chip superio/exar/xr28v382 # Super I/O > device pnp 2e.0 on # Com1 > io 0x60 = 0x3f8 > irq 0x70 = 4 > end > device pnp 2e.1 off # Com2 > end > device pnp 2e.8 off # Watchdog > end > end > device pci 1f.3 on end # SMBus 0 > > Now the output of the console log (DEBUG level): > <...> > PCI: pci_scan_bus for bus 00 > PCI: 00:00.0 [8086/1f0f] enabled > PCI: Static device PCI: 00:01.0 not found, disabling it. > child PNP: 002e.0 not a PCI device > child PNP: 002e.1 not a PCI device > child PNP: 002e.8 not a PCI device > child PNP: 002e.0 not a PCI device > child PNP: 002e.1 not a PCI device > child PNP: 002e.8 not a PCI device > child PNP: 002e.0 not a PCI device > child PNP: 002e.1 not a PCI device > child PNP: 002e.8 not a PCI device > child PNP: 002e.0 not a PCI device > <...> > PCI: 00:1f.0 [8086/1f38] enabled > child PNP: 002e.0 not a PCI device > child PNP: 002e.1 not a PCI device > child PNP: 002e.8 not a PCI device > child PNP: 002e.0 not a PCI device > child PNP: 002e.1 not a PCI device > child PNP: 002e.8 not a PCI device > child PNP: 002e.0 not a PCI device > child PNP: 002e.1 not a PCI device > child PNP: 002e.8 not a PCI device > PCI: 00:1f.3 [8086/1f3c] enabled > child PNP: 002e.0 not a PCI device > <...> > PCI: Left over static devices: > PNP: 002e.0 > PNP: 002e.1 > PNP: 002e.8 > PCI: Check your devicetree.cb. > PCI: pci_scan_bus for bus 01 > <...> > DOMAIN: 0000 (Intel Rangeley Northbridge) > PCI: 00:00.0 (Intel Rangeley Northbridge) > PCI: 00:01.0 (Intel Rangeley Northbridge) > PCI: 00:02.0 (Intel Rangeley Northbridge) > PCI: 00:03.0 (Intel Rangeley Northbridge) > PCI: 00:04.0 (Intel Rangeley Northbridge) > PCI: 00:0b.0 (Intel Rangeley Southbridge) > PCI: 00:0e.0 (Intel Rangeley Southbridge) > PCI: 00:13.0 (Intel Rangeley Southbridge) > PCI: 00:14.0 (Intel Rangeley Southbridge) > PCI: 00:14.1 (Intel Rangeley Southbridge) > PCI: 00:14.2 (Intel Rangeley Southbridge) > PCI: 00:14.3 (Intel Rangeley Southbridge) > PCI: 00:16.0 (Intel Rangeley Southbridge) > PCI: 00:17.0 (Intel Rangeley Southbridge) > PCI: 00:18.0 (Intel Rangeley Southbridge) > PCI: 00:1f.0 (Intel Rangeley Southbridge) > PNP: 002e.0 (EXAR XR28V382 Super I/O) > PNP: 002e.1 (EXAR XR28V382 Super I/O) > PNP: 002e.8 (EXAR XR28V382 Super I/O) > PCI: 00:1f.3 (Intel Rangeley Southbridge) > PCI: 00:0f.0 (unknown) > PCI: 01:00.0 (unknown) > > I guess that the "" are not normal, isn't it ? > And so the " Check your devicetree.cb." ? > Moreover, I put a printk() in the init function of the chip and do not see > it in the log. > What particular point should I also check to be sure that I do not miss > anything ? > > Thanks for your help. > Best regards, > Patrick Agrain > > -- > coreboot mailing list: [email protected] > https://www.coreboot.org/mailman/listinfo/coreboot >
-- coreboot mailing list: [email protected] https://www.coreboot.org/mailman/listinfo/coreboot
