How about just changing the die() into a printk(BIOS_ALERT, ...) and an assert(0)? Then people could use CONFIG_FATAL_ASSERTS to select whether they would rather fail fast or try to keep booting as far as possible.
On Fri, Feb 24, 2017 at 7:46 AM, ron minnich <[email protected]> wrote: > For those of us working on boards that don't ship in a product, the die() > is probably not appropriate. But if you intend to ship a real product then > you definitely want to die() if someone tries to use a CPU that's not > tested on the board. > > Or at least that's the way it seems to me. > > On Fri, Feb 24, 2017 at 7:42 AM Aaron Durbin via coreboot < > [email protected]> wrote: > >> On Fri, Feb 24, 2017 at 5:04 AM, <[email protected]> wrote: >> > Yes, this die() is what i mean. Try to get maybe some functionality is i >> > think better then just stopping there and providing zero functionality. >> > >> > I also know, that there is a message when the CPUID is not known. Its >> about >> > the die() afterwards. >> >> Patches always welcome. Did you try removing the die() and seeing if >> things actually booted? >> >> > >> > >> > 23. Feb 2017 14:31 by [email protected]: >> > >> > On Thu, Feb 23, 2017 at 2:39 AM, Nico Huber <[email protected]> wrote: >> > >> > On 23.02.2017 00:07, [email protected] wrote: >> > >> > There is a Filter to stop booting when the CPUID is not in a list of >> > supported CPUs. This filter does not make sense in the real world usage. >> > >> > >> > It's not a filter. It's a measure to know which code to run for which >> > CPU. Please dig a little deeper before making such useless complaints. >> > >> > >> > To add to Nico's point: the cpuid list is a way to bind code code to >> > run for certain devices -- including CPUs. If the cpuid is not listed >> > then the match on device->code to run is not met. Therefore, the code >> > necessary to make that CPU work won't ever be ran. src/arch/x86/cpu.c >> > has the cpu driver binding. And there already is message printed. See >> > the callers of set_cpu_ops() in that file. The issue is that we die() >> > when no match is found. We could attempt to boot further, but there's >> > no guarantee it'd actually succeed. >> > >> > >> > Nico >> > >> > -- >> > coreboot mailing list: [email protected] >> > https://www.coreboot.org/mailman/listinfo/coreboot >> > >> > >> > -- >> > coreboot mailing list: [email protected] >> > https://www.coreboot.org/mailman/listinfo/coreboot >> >> -- >> coreboot mailing list: [email protected] >> https://www.coreboot.org/mailman/listinfo/coreboot >> > > -- > coreboot mailing list: [email protected] > https://www.coreboot.org/mailman/listinfo/coreboot >
-- coreboot mailing list: [email protected] https://www.coreboot.org/mailman/listinfo/coreboot
