Hi Aaron, The patches are in draft as the migration was in progress, hence you were not able to access. Not sure how this triggered email even when you were not added yet
Will publish it later today. Thanks and Regards Balaji -----Original Message----- From: Aaron Durbin [mailto:[email protected]] Sent: Tuesday, March 28, 2017 8:43 PM To: Coreboot <[email protected]>; Banik, Subrata <[email protected]> Cc: Manigandan, Balaji <[email protected]>; [email protected]; Solanki, Naresh <[email protected]>; Sarkar, Barnali <[email protected]>; Qureshi, Rizwan <[email protected]> Subject: Re: [coreboot-gerrit] Change in coreboot[master]: KBL: Update FSP headers - upgrade to FSP.2.0.0 Why can't I access this CL on gerrit, but I'm getting emails for it? On Tue, Mar 28, 2017 at 10:10 AM, Subrata Banik (Code Review) <[email protected]> wrote: > Subrata Banik has posted comments on this change. ( > https://review.coreboot.org/19023 ) > > Change subject: KBL: Update FSP headers - upgrade to FSP.2.0.0 > ...................................................................... > > > Patch Set 3: > > (2 comments) > > https://review.coreboot.org/#/c/19023/3/src/vendorcode/intel/fsp/fsp2_ > 0/skykabylake/ConfigBlock/CpuConfigFspData.h > File > src/vendorcode/intel/fsp/fsp2_0/skykabylake/ConfigBlock/CpuConfigFspData.h: > > PS3, Line 66: } Bits; > : UINT32 Uint32[2]; > : } CPU_CONFIG_FSP_DATA; > why added space? don't we run clean up script? > > > https://review.coreboot.org/#/c/19023/3/src/vendorcode/intel/fsp/fsp2_ > 0/skykabylake/FspmUpd.h File > src/vendorcode/intel/fsp/fsp2_0/skykabylake/FspmUpd.h: > > PS3, Line 41: #include <MemInfoHob.h> > directory structure change > ?? > > > -- > To view, visit https://review.coreboot.org/19023 To unsubscribe, visit > https://review.coreboot.org/settings > > Gerrit-MessageType: comment > Gerrit-Change-Id: Id8ecea6fa5f4e7a72410f8da535ab9c4808b3482 > Gerrit-PatchSet: 3 > Gerrit-Project: coreboot > Gerrit-Branch: master > Gerrit-Owner: Balaji Manigandan <[email protected]> > Gerrit-Reviewer: Barnali Sarkar <[email protected]> > Gerrit-Reviewer: Naresh Solanki <[email protected]> > Gerrit-Reviewer: Rizwan Qureshi <[email protected]> > Gerrit-Reviewer: Subrata Banik <[email protected]> > Gerrit-HasComments: Yes > > -- > coreboot-gerrit mailing list: [email protected] > https://www.coreboot.org/mailman/listinfo/coreboot-gerrit -- coreboot mailing list: [email protected] https://www.coreboot.org/mailman/listinfo/coreboot
