-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 06/06/2017 01:30 PM, Nico Huber wrote: > On 06.06.2017 19:28, Raptor Engineering Automated Coreboot Test Stand wrote: >> The ASUS KFSN4-DRE fails verification for branch master as of commit >> 00b9f4c4b1cd95a6cafe2b1e66641ff0f113082e >> >> The following tests failed: >> BOOT_FAILURE >> >> Commits since last successful test: >> 00b9f4c mb/*/*/cmos.layout: Make multibyte options byte aligned > > This might be the culprit. The position of `ecc_scrub_rate` in CMOS > changed. > > If this turns out to have caused a boot failure, may I ask, why is that > an NVRAM option? and why are values allowed that can fail to boot? > > Nico
It's an NVRAM option to allow for potentially unusual use cases, such as an archive file server where data integrity may be more important than overall system speed. That being said, none of the allowed values should cause a boot failure, and a boot failure due to this particular NVRAM setting in isolation should be considered a bug. I wonder if there are functional sanity checks on the values read from NVRAM for this particular option or not? - -- Timothy Pearson Raptor Engineering +1 (415) 727-8645 (direct line) +1 (512) 690-0200 (switchboard) https://www.raptorengineering.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJZNvZTAAoJEK+E3vEXDOFboIkH/RAdXrqSBzLDghlZMGcPkZFU UTckiucV+5s/Ajue+t67oUlpBegw7cVYhx7iKlCVqzVGlinjgkqtiOrTvgB5EtB2 6VNm3uxMdFL+MV4q47t727+qHsiJUrQ5Cxy2S4pxGZcJlV/VRrCnGx2dx+gw9I3c 0DRtFEUZtZPqxXcDKI5PE1QDPjAlYRIpT3/48wE8/4aiDbaj6vVsmlL4zfFs/lxj mgVh960CVf4sZQNPagjbUT+6ObDUBDItsaQW3Wu4k6n6Luwu5zGVoTJ6apl9ZXLj v7DGPMeWkzcqr2A37HZSf2w6qnpkWElZLeujC3mQfO1luizK/HgzuCZo7qjplG8= =c4fH -----END PGP SIGNATURE----- -- coreboot mailing list: coreboot@coreboot.org https://mail.coreboot.org/mailman/listinfo/coreboot
