Hi,

Sorry for the delay.> CPU ID 0x80000001: fc0

So your CPU is revision "DH" which is pre "F".

> But I have also seen that CONFIG_K8_REV_F_SUPPORT is not set in .config

nope this is for some other CPUs.

If you look to coreboot/src/cpu/amd/model_fxx/powernow_acpi.c, your CPU 0xfc0
has an entry there.

You need to check pstates_algorithm() function. It may not be executed at all,
or there is something wrong with that. Make sure that you look to the later one,
there is #ifdef in this file! The first one is for CONFIG_K8_REV_F_SUPPORT.

This functionality is called from amd_generate_powernow()
which goes from via/k8t890/traf_ctrl.c

I suspect that this old VIA chipset has no PCI device for this thus the

.acpi_fill_ssdt_generator = southbridge_acpi_fill_ssdt_generator

Is never called. I did not do the support for the K8T800 chipset so I don't
know. Maybe you can provide lspci -xxx -n from linux to see what kind of PCI
devices you have. Perhaps then the callback can be added elsewhere to the PCI
device you have such as  northbridge_driver_t800_old.

You can try attached patch, maybe it will move you further. I remember it was
real pain to get the cool-n-quiet working, there was a lot of southbridge tweaks
necessary (and undocumented bits!). Just give it a try. In worst case you will
see some messages in dmesg about Targ stuck bits...

Thanks
Rudolf


diff --git a/src/southbridge/via/k8t890/host.c b/src/southbridge/via/k8t890/host.c
index 2155594..2dd2896 100644
--- a/src/southbridge/via/k8t890/host.c
+++ b/src/southbridge/via/k8t890/host.c
@@ -82,12 +82,26 @@ static void host_init(struct device *dev)
 
 }
 
+
+#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)
+
+static void southbridge_acpi_fill_ssdt_generator(device_t dev) {
+
+	amd_generate_powernow(0, 0, 0);
+	acpigen_write_mainboard_resources("\\_SB.PCI0.MBRS", "_CRS");
+}
+#endif
+
 static const struct device_operations host_ops_old = {
 	.read_resources		= pci_dev_read_resources,
 	.set_resources		= pci_dev_set_resources,
 	.enable_resources	= pci_dev_enable_resources,
 	.enable			= host_old_enable,
 	.init			= host_old_init,
+#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)
+	.write_acpi_tables      = acpi_write_hpet,
+	.acpi_fill_ssdt_generator = southbridge_acpi_fill_ssdt_generator,
+#endif
 	.ops_pci		= 0,
 };
 
-- 
coreboot mailing list: [email protected]
https://mail.coreboot.org/mailman/listinfo/coreboot

Reply via email to