Sounds good to me, too. Then we finally will avoid forgetting the CONIFG_ prefix.
Werner > -----Ursprüngliche Nachricht----- > Von: Patrick Rudolph <[email protected]> > Gesendet: Mittwoch, 6. März 2019 08:26 > An: Julius Werner <[email protected]>; Coreboot <[email protected]> > Betreff: [coreboot] Re: RFC: Replacing IS_ENABLED(CONFIG_XXX) with the > shorter CONFIG(XXX) > > On Tue, 2019-03-05 at 17:52 -0800, Julius Werner wrote: > > Hi folks, > > > > I'm proposing a small policy change for the way we refer to boolean > > Kconfig variables in code. Right now, the directive is to always use > > the IS_ENABLED() macro. I would like to replace this with a shorter > > macro CONFIG() that also removes the need to type the CONFIG_ prefix > > again. The idea is mostly to save some horizontal space and the > > occasional extra line break for this boilerplate and make it a little > > easier to type. > > > Sounds like a good plan. Please keep Documentation in sync: > Documentation/core/Kconfig.md seems to cover the implementation details. > > > It's a very simple change (patch train starts at > > https://review.coreboot.org/c/coreboot/+/31773), but since it affects > > pretty much all code in coreboot and payloads I wanted to send out a > > quick FYI. Please let me know if anyone has any concerns with this. > > _______________________________________________ > > coreboot mailing list -- [email protected] To unsubscribe send an > > email to [email protected] > -- > Patrick Rudolph > > 9elements Agency GmbH, Kortumstraße 19-21, 44787 Bochum, Germany > Email: [email protected] > Phone: +49 234 68 94 188 > > Sitz der Gesellschaft: Bochum > Handelsregister: Amtsgericht Bochum, HRB 17519 > Geschäftsführung: Sebastian Deutsch, Daniel Hoelzgen > _______________________________________________ > coreboot mailing list -- [email protected] To unsubscribe send an email > to [email protected] _______________________________________________ coreboot mailing list -- [email protected] To unsubscribe send an email to [email protected]
