On Tue, Nov 05, 2019 at 02:26:25PM +0100, Nico Huber wrote: > So, we already have Gerrit guidelines [1]. While they are most often > not worth a look (common sense usually is enough), some people like > to be reminded of them regularly. The latter is pretty annoying and > doesn't seem to help. Most of them aren't easily testable, so I guess the best we could do to reduce the pain about that is to add some prominent link to it in the Gerrit UI. Would that help?
> I propose to add some lines what should happen when somebody delibe- > rately ignores the guidelines. One such case that I often see is > rubber-stamping of huge commits. One person's rubber-stamp is another person's "I know you plan to work on this, and you have a reason for doing it this way". > Reviewers who rubber-stamp bigger code additions will be demoted > by one group on Gerrit. They can only return to the higher group > after one hour per rubber-stamped, added line. > > Sounds easy and fair, I'd say. What do you think? I don't see how this is easy: The first issue I see is "who is not taking responsibility?", a judgement that certainly differs from person to person, and context to context. Next: Assuming multiple reviewers +2 and are found "not to take responsibility", does everybody get one hour per rubber-stamped, added line, or will the lines be split among them? Next: When is the penalty implemented? If it happens right before my vacation, I might not care too much ;-) In general, I'm not opposed to removing privileges on Gerrit (so that you can lose them over time just like you can gain them) based on unprofessional behavior, but the mechanics are far from clear to me. I wouldn't do it time-based, either: you don't end up in the CR+2 and submit group just because your account lingered around on Gerrit for X days. Patrick -- Google Germany GmbH, ABC-Str. 19, 20354 Hamburg Registergericht und -nummer: Hamburg, HRB 86891, Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
signature.asc
Description: PGP signature
_______________________________________________ coreboot mailing list -- [email protected] To unsubscribe send an email to [email protected]
