On 05.12.2019 10:13, Jorge Fernandez Monteagudo wrote: > Hi all, > > I've been able to make it work the Bettong board again with the commit before > a0a50775 > as Kyösti Mälkki pointed. I've had to remove the next commit to make it work > again. > > bfb5c807e720761f4457d5106bb919f2aacb5535 binaryPI: Drop PSP Secure OS from > build > > and some minor changes. I really want to upload the board status but I'm > still trying to make > the git push to work, I stil can't login. I've attached the tar.gz related to > the path: > > util/board_status/board-status/amd/bettong/4.11-128-gb64f85d/2019-12-05T09_00_28Z > > if could be useful...
You can try setting up SSH key on the gerrit account and change the git remote to SSH instead of HTTPS. Regards, -- Michał Żygowski Firmware Engineer http://3mdeb.com | @3mdeb_com > > Regards, > Jorge > > Complete minor changes patch: > > diff --git a/src/commonlib/include/commonlib/helpers.h > b/src/commonlib/include/commonlib/helpers.h > index ca3b3c5..d980827 100644 > --- a/src/commonlib/include/commonlib/helpers.h > +++ b/src/commonlib/include/commonlib/helpers.h > @@ -50,10 +50,10 @@ > #endif > > #ifndef MIN > -#define MIN(a, b) __CMP(a, b, <) > +#define MIN(a, b) ((a) < (b) ? (a) : (b)) > #endif > #ifndef MAX > -#define MAX(a, b) __CMP(a, b, >) > +#define MAX(a, b) ((a) > (b) ? (a) : (b)) > #endif > > #ifndef ABS > diff --git a/src/northbridge/amd/pi/00660F01/acpi/northbridge.asl > b/src/northbridge/amd/pi/00660F01/acpi/northbridge.asl > index d54f985..ac44f46 100644 > --- a/src/northbridge/amd/pi/00660F01/acpi/northbridge.asl > +++ b/src/northbridge/amd/pi/00660F01/acpi/northbridge.asl > @@ -18,7 +18,7 @@ External (TOM1) > External (TOM2) > Name(_HID, EISAID("PNP0A08")) /* PCI Express Root Bridge */ > Name(_CID, EISAID("PNP0A03")) /* PCI Root Bridge */ > -Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ > +//Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ > > /* Describe the Northbridge devices */ > > diff --git a/src/southbridge/amd/pi/hudson/Makefile.inc > b/src/southbridge/amd/pi/hudson/Makefile.inc > index 0eccadb..33f59c7 100644 > --- a/src/southbridge/amd/pi/hudson/Makefile.inc > +++ b/src/southbridge/amd/pi/hudson/Makefile.inc > @@ -85,10 +85,10 @@ FIRMWARE_LOCATE=$(dir $(call strip_quotes, > $(CONFIG_AMD_PUBKEY_FILE))) > FIRMWARE_TYPE= > > PSPBTLDR_FILE=$(top)/$(FIRMWARE_LOCATE)/PspBootLoader.Bypass.sbin > -#PSPRCVR_FILE=$(top)/$(FIRMWARE_LOCATE)/PspRecovery.sbin > -#PSPSCUREOS_FILE=$(top)/$(FIRMWARE_LOCATE)/PspSecureOs.sbin > -#PSPTRUSTLETS_FILE=$(top)/$(FIRMWARE_LOCATE)/trustlets.bin > -#TRUSTLETKEY_FILE=$(top)/$(FIRMWARE_LOCATE)/Trustlet.tkn.cert > +PSPRCVR_FILE=$(top)/$(FIRMWARE_LOCATE)/PspRecovery.sbin > +PSPSCUREOS_FILE=$(top)/$(FIRMWARE_LOCATE)/PspSecureOs.sbin > +PSPTRUSTLETS_FILE=$(top)/$(FIRMWARE_LOCATE)/trustlets.bin > +TRUSTLETKEY_FILE=$(top)/$(FIRMWARE_LOCATE)/Trustlet.tkn.cert > endif > > ifeq ($(CONFIG_CPU_AMD_PI_00660F01), y) > @@ -103,12 +103,12 @@ > TRUSTLETKEY_FILE=$(top)/$(FIRMWARE_LOCATE)/TrustletKey_prod_CZ.sbin > SMUFIRMWARE2_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuFirmware2_prod_CZ.sbin > endif > > -#PUBSIGNEDKEY_FILE=$(top)/$(FIRMWARE_LOCATE)/RtmPubSigned$(FIRMWARE_TYPE).key > -#PSPNVRAM_FILE=$(top)/$(FIRMWARE_LOCATE)/PspNvram$(FIRMWARE_TYPE).bin > +PUBSIGNEDKEY_FILE=$(top)/$(FIRMWARE_LOCATE)/RtmPubSigned$(FIRMWARE_TYPE).key > +PSPNVRAM_FILE=$(top)/$(FIRMWARE_LOCATE)/PspNvram$(FIRMWARE_TYPE).bin > SMUFWM_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuFirmware$(FIRMWARE_TYPE).sbin > SMUFWM_FN_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuFirmware$(FIRMWARE_TYPE)_FN.sbin > SMUSCS_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuScs$(FIRMWARE_TYPE).bin > -#PSPSECUREDEBUG_FILE=$(top)/$(FIRMWARE_LOCATE)/PspSecureDebug$(FIRMWARE_TYPE).Key > +PSPSECUREDEBUG_FILE=$(top)/$(FIRMWARE_LOCATE)/PspSecureDebug$(FIRMWARE_TYPE).Key > > endif > > > _______________________________________________ > coreboot mailing list -- [email protected] > To unsubscribe send an email to [email protected]
_______________________________________________ coreboot mailing list -- [email protected] To unsubscribe send an email to [email protected]
