Below is a patch that does what I want for one of the points I
mentioned. Comments? Does this interfere with a different use case?
On 2020-06-01 9:16 a.m., Jeremy Jackson wrote:
Hello Coreboot,
I am looking at upgrading a Lenovo T60 that has a 4 year old Libreboot
installed. Looking to try git master today, I find myself tracking
down some details of how the old version was built. While the
included .config is invaluable, I'm getting a few ideas for improvements.
....
-the .config is overwritten when added to coreboot.rom via CBFS at the
end of the build (if you choose that option)... should this be a
separate file for each of fallback and normal? Since there can be two
different versions and/or configurations, would fallback/config and
normal/config make more sense? Also the "revision" file might benefit
from similar treatment. Need to look into cmos* files also.
diff --git a/Makefile.inc b/Makefile.inc
index 86467a66a8..b547f11ede 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -1195,13 +1195,13 @@ cbfs-files-$(CONFIG_SEABIOS_VGA_COREBOOT) +=
vgaroms/seavgabios.bin
vgaroms/seavgabios.bin-file := $(CONFIG_PAYLOAD_VGABIOS_FILE)
vgaroms/seavgabios.bin-type := raw
-cbfs-files-$(CONFIG_INCLUDE_CONFIG_FILE) += config
-config-file := $(DOTCONFIG):defconfig
-config-type := raw
+cbfs-files-$(CONFIG_INCLUDE_CONFIG_FILE) += $(CONFIG_CBFS_PREFIX)/config
+$(CONFIG_CBFS_PREFIX)/config-file := $(DOTCONFIG):defconfig
+$(CONFIG_CBFS_PREFIX)/config-type := raw
-cbfs-files-$(CONFIG_INCLUDE_CONFIG_FILE) += revision
-revision-file := $(obj)/build.h
-revision-type := raw
+cbfs-files-$(CONFIG_INCLUDE_CONFIG_FILE) += $(CONFIG_CBFS_PREFIX)/revision
+$(CONFIG_CBFS_PREFIX)/revision-file := $(obj)/build.h
+$(CONFIG_CBFS_PREFIX)/revision-type := raw
BOOTSPLASH_SUFFIX=$(suffix $(call
strip_quotes,$(CONFIG_BOOTSPLASH_FILE)))
cbfs-files-$(CONFIG_BOOTSPLASH_IMAGE) += bootsplash$(BOOTSPLASH_SUFFIX)
Perhaps each should be discussed in a separate thread, I'll leave that
to others' discretion.
Regards,
Jeremy
_______________________________________________
coreboot mailing list -- [email protected]
To unsubscribe send an email to [email protected]
