Hi,
Please find the latest report on new defect(s) introduced to coreboot found
with Coverity Scan.
6 new defect(s) introduced to coreboot found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 6 of 6 defect(s)
** CID 1429983: Control flow issues (DEADCODE)
/src/drivers/uart/acpi/acpi.c: 104 in uart_acpi_fill_ssdt()
________________________________________________________________________________________________________
*** CID 1429983: Control flow issues (DEADCODE)
/src/drivers/uart/acpi/acpi.c: 104 in uart_acpi_fill_ssdt()
98 reset_gpio_index >= 0 || enable_gpio_index >= 0) {
99 struct acpi_dp *dsd = acpi_dp_new_table("_DSD");
100 if (config->compat_string)
101 acpi_dp_add_string(dsd, "compatible",
102 config->compat_string);
103 if (irq_gpio_index >= 0)
>>> CID 1429983: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "acpi_dp_add_gpio(dsd, "irq-...".
104 acpi_dp_add_gpio(dsd, "irq-gpios", path,
105 irq_gpio_index, 0,
106 config->irq_gpio.polarity);
107 if (reset_gpio_index >= 0)
108 acpi_dp_add_gpio(dsd, "reset-gpios", path,
109 reset_gpio_index, 0,
** CID 1429982: Null pointer dereferences (NULL_RETURNS)
________________________________________________________________________________________________________
*** CID 1429982: Null pointer dereferences (NULL_RETURNS)
/src/drivers/intel/pmc_mux/mux.c: 16 in mux_fill_ssdt()
10 {
11 return "MUX";
12 }
13
14 static void mux_fill_ssdt(const struct device *dev)
15 {
>>> CID 1429982: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a pointer that might be "NULL" "acpi_device_scope(dev)"
>>> when calling "acpigen_write_scope".
16 acpigen_write_scope(acpi_device_scope(dev));
17 acpigen_write_device(acpi_device_name(dev));
18
19 acpigen_write_name_string("_HID", TGL_PMC_MUX_HID);
20 acpigen_write_name_string("_DDN", dev->chip_ops->name);
21
** CID 1429981: Null pointer dereferences (NULL_RETURNS)
________________________________________________________________________________________________________
*** CID 1429981: Null pointer dereferences (NULL_RETURNS)
/src/soc/intel/tigerlake/pmc.c: 104 in soc_pmc_fill_ssdt()
98 res->limit = res->base + res->size - 1;
99 res->flags = IORESOURCE_IO | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
100 }
101
102 static void soc_pmc_fill_ssdt(const struct device *dev)
103 {
>>> CID 1429981: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a pointer that might be "NULL" "acpi_device_scope(dev)"
>>> when calling "acpigen_write_scope".
104 acpigen_write_scope(acpi_device_scope(dev));
105 acpigen_write_device(acpi_device_name(dev));
106
107 acpigen_write_name_string("_HID", PMC_HID);
108 acpigen_write_name_string("_DDN", "Intel(R) Tiger Lake IPC
Controller");
109
** CID 1429980: Null pointer dereferences (NULL_RETURNS)
________________________________________________________________________________________________________
*** CID 1429980: Null pointer dereferences (NULL_RETURNS)
/src/soc/amd/picasso/root_complex.c: 138 in root_complex_fill_ssdt()
132
133 /* Used by \_SB.PCI0._CRS */
134 static void root_complex_fill_ssdt(const struct device *device)
135 {
136 msr_t msr;
137
>>> CID 1429980: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a pointer that might be "NULL"
>>> "acpi_device_scope(device)" when calling "acpigen_write_scope".
138 acpigen_write_scope(acpi_device_scope(device));
139
140 msr = rdmsr(TOP_MEM);
141 acpigen_write_name_dword("TOM1", msr.lo);
142 msr = rdmsr(TOP_MEM2);
143 /*
** CID 1429979: Null pointer dereferences (NULL_RETURNS)
________________________________________________________________________________________________________
*** CID 1429979: Null pointer dereferences (NULL_RETURNS)
/src/drivers/intel/pmc_mux/con/con.c: 37 in con_fill_ssdt()
31 struct acpi_dp *dsd;
32
33 if (!dev->enabled)
34 return;
35
36 /* Reference the existing scope and write CONx device */
>>> CID 1429979: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a pointer that might be "NULL" "acpi_device_scope(dev)"
>>> when calling "acpigen_write_scope".
37 acpigen_write_scope(acpi_device_scope(dev));
38 acpigen_write_device(acpi_device_name(dev));
39
40 acpigen_write_name_integer("_ADR", dev->path.generic.id);
41
42 /* _DSD, Device-Specific Data */
** CID 1420207: Null pointer dereferences (NULL_RETURNS)
________________________________________________________________________________________________________
*** CID 1420207: Null pointer dereferences (NULL_RETURNS)
/src/superio/nuvoton/npcd378/superio.c: 328 in npcd378_ssdt_pwr()
322
323 acpigen_pop_len(); /* Pop SIOS method */
324
325 acpigen_pop_len(); /* Pop Scope */
326
327 /* Inject into parent: */
>>> CID 1420207: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a pointer that might be "NULL" "acpi_device_scope(dev)"
>>> when calling "acpigen_write_scope".
328 acpigen_write_scope(acpi_device_scope(dev));
329
330 acpigen_write_name_integer("MSFG", 1);
331 acpigen_write_name_integer("KBFG", 1);
332 acpigen_write_name_integer("PMFG", 0);
333
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://u2389337.ct.sendgrid.net/ls/click?upn=nJaKvJSIH-2FPAfmty-2BK5tYpPklAc1eEA-2F1zfUjH6teExSZiGT4AO9dqB-2BC868xZOCag75Y7p1UmqAHPbZ6SCvYLXjumWuqPoaDGx7Muigyow-3DYYrQ_L-2FDzr14mnrsJO5b1wX1hp9b1MAQygl7x-2B74RAaH2cn06z5B-2B-2BnTuuxqtpFb1DryQrhWMejopCdmzrPk-2FWWW-2BiVwN5jQdDLKDszxfRvrSiT2evrcLtwzc4zbJhnVqi6WmOvx90yATW0hxBhIFQWGD8D-2FVcbb-2BY0q-2BV90StRRZLq7bJqkqKc80ubFWmoNRWG8FKDVb8SUQ-2FlBc2ilKxzZculIpCjKNxYad4D58Os-2BZ-2Bv8-3D
_______________________________________________
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-le...@coreboot.org
