FSP-T isn't used for APL/GLK Chromebooks. Sounds like your .config is selecting something it shouldn't. run `make savedefconfig` then post the contents of the defconfig. Possible CONFIG_USE_APOLLOLAKE_FSP_CAR is selected when it shouldn't be.
On Mon, Jun 21, 2021 at 9:17 PM James Feeney <[email protected]> wrote: > > $ cat defconfig > ... > CONFIG_ADD_FSP_BINARIES=y > ... > > There is *no* "fspt.bin" file in this chromebook recovery bios file used as > source. > > > $ make > ... > src/soc/intel/apollolake/fspcar.c:3:10: fatal error: FsptUpd.h: No such file > or directory > #include <FsptUpd.h> > ^~~~~~~~~~~ > compilation terminated. > make: *** [Makefile:379: build/bootblock/soc/intel/apollolake/fspcar.o] Error > 1 > > > What Makefile is that? There is no such line 379. > > > $ find -name FsptUpd.h > ... > ./3rdparty/fsp/ApolloLakeFspBinPkg/Include/FsptUpd.h > ... > > > > $ less src/soc/intel/alderlake/Kconfig > ... > config FSP_HEADER_PATH > string "Location of FSP headers" > default "src/vendorcode/intel/fsp/fsp2_0/alderlake/" > > > $ less src/drivers/intel/fsp2_0/Kconfig > ... > > config FSP_T_FILE > string "Intel FSP-T (temp RAM init) binary path and filename" if > !FSP_FULL_FD > depends on ADD_FSP_BINARIES > depends on FSP_CAR > default "\$(obj)/Fsp_T.fd" if FSP_FULL_FD > help > The path and filename of the Intel FSP-T binary for this platform. > > > > > $ make nconfig > ... > > Generic Drivers > ... > (src/vendorcode/intel/fsp/fsp2_0/glk) Location of FSP headers > > How did that get there? Not me... > > $ ll src/vendorcode/intel/fsp/fsp2_0/glk > total 116 > drwxr-x--- 2 james james 4096 Oct 29 2020 . > drwxr-x--- 9 james james 4096 Jun 14 19:04 .. > -rw-r----- 1 james james 45977 Oct 29 2020 FspmUpd.h > -rw-r----- 1 james james 57332 Oct 29 2020 FspsUpd.h > -rw-r----- 1 james james 1967 Oct 29 2020 FspUpd.h > > > Why is src/soc/intel/apollolake/fspcar.c being built here? It seems that no > fspt.bin file is needed. > > > James > _______________________________________________ > coreboot mailing list -- [email protected] > To unsubscribe send an email to [email protected] _______________________________________________ coreboot mailing list -- [email protected] To unsubscribe send an email to [email protected]
