I just looked at the patch, it does not reenable continuous mode in ramstage. So what I do is basically the same with that patch, but that doesn't work after a warm reset for me.
I am wondering whether the gpio configuration of the soc is related to this issue, I don't have access to the BWG doc, can anybody send me a copy? SMbus also doesn't working, don't know if it is related to the gpio setting. On Mon, 8 Nov 2021 15:31:34 +0800 Lance Zhao <[email protected]> wrote: > https://u8209486.ct.sendgrid.net/ls/click?upn=5-2BjrOL6Sde2a9aQLMiEgaLzceDV6ek3hr5PekV6loyqk65QWgl6iFUXTzf0xmiYdJQqz2O-2BmNofuvhc-2BSUW42g-3D-3DIS0P_L-2FDzr14mnrsJO5b1wX1hp9b1MAQygl7x-2B74RAaH2cn21TG6bW8nMJzCNcSTjONGyI1M5bAf7RoAcsDx-2BKzp1xHjPbNbX9YRJ9jgCdIuN2Fp1942mfH3JQ8872vhDmLFPBowMwb5R0penb0NOVD0S1O5rgFPMPEdRHikNuvSn3NYth1DsL8Osu3GOEZ-2FmsVgvbKsuaHTUPGrNm68Bk27S-2BOWZPG30b-2FxX-2Fr5jaNand2U-3D > Have similar implementation on braswell, so as long as sc_init get > executed in ramstage the serial irq mode programming shall be working. > > Zhiwen Zheng <[email protected]> 于2021年11月6日周六 下午6:29写道： > > > I add the following code to sc_init() in southcluster.c to enable SERIRQ, > > and it works as expected when doing cold boot. With SERIRQ enabled, the > > uart in superio can function correctly, and I can login into the linux > > serial console. But after a reboot initiated from linux cmdline, the linux > > boot hang in getty serial(same as without SERIRQ enabled), only a power > > cycle can resolve the issue. I take the following code from coreboot-4.11 > > fsp-baytrail. I also tried the check_for_warm_reset() in bootblock.c to > > hardreset the machine, but the check condition in that procedure doesn't > > catch this situation, linux reset by default use keyboard controller > > seemingly. > > > > u32 *oic = (u32 *)(ILB_BASE_ADDRESS + 0x60); > > u8 *serirq_cntl = (u8 *)(ILB_BASE_ADDRESS + 0x10); > > > > > > /* Enable SERIRQ */ > > write32(oic, (read32(oic) | (1 << 12))); > > /* Enable continuous mode */ > > write8(serirq_cntl, (1 << 7)); > > _______________________________________________ > > coreboot mailing list -- [email protected] > > To unsubscribe send an email to [email protected] > > _______________________________________________ coreboot mailing list -- [email protected] To unsubscribe send an email to [email protected]
