Issue #456 has been updated by Martin Roth.

I'll re-create the archive.  I'd fixed the bug with the timestamps, but it must 
not have been included in the script that generated these tarballs.

For naming, I'd rather not go with -2 unless we create a new tag.  I think 
something like coreboot-4.19.fixed.tar.xz would be more appropriate.

----------------------------------------
Bug #456: coreboot 4.19 tarballs have bad timestamps
https://ticket.coreboot.org/issues/456#change-1403

* Author: Thierry Laurion
* Status: New
* Priority: High
* Category: infrastructure
* Target version: 4.19
* Start date: 2023-02-08
* Affected versions: 4.19, master
* Needs backport to: 4.19, master
----------------------------------------
As reported on #coreboot channel, coreboot 4.19 tarballs contain invalid 
timestamps (year 1901) for all contained files.

Reproducility of issue:
wget https://www.coreboot.org/releases/coreboot-4.19.tar.xz
user@heads-tests:/tmp/test$ ls -al coreboot-4.19.tar.xz 
-rw-r--r-- 1 user user 56908588 Jan 26 21:46 coreboot-4.19.tar.xz
user@heads-tests:/tmp/test$ tar Jxvf coreboot-4.19.tar.xz 
coreboot-4.19/
coreboot-4.19/.checkpatch.conf
tar: coreboot-4.19/.checkpatch.conf: implausibly old time stamp 
-9223372036854775808
coreboot-4.19/.clang-format
tar: coreboot-4.19/.clang-format: implausibly old time stamp 
-9223372036854775808
coreboot-4.19/.coreboot-version
tar: coreboot-4.19/.coreboot-version: implausibly old time stamp 
-9223372036854775808
coreboot-4.19/.crossgcc-version
tar: coreboot-4.19/.crossgcc-version: implausibly old time stamp 
-9223372036854775808
coreboot-4.19/.editorconfig
tar: coreboot-4.19/.editorconfig: implausibly old time stamp 
-9223372036854775808

Cause:
@icon investigated and said "d05ea79e40c4 util/release/build-release: Fix style 
issues
at least that change to the tstamp variable looks very suspicious"

flx suggested to recreate the archive: "I think 4.19-2 would be better. There 
are no changes to coreboot or anything. It also doesn't need a new git tag"
 



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
https://ticket.coreboot.org/my/account
_______________________________________________
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-le...@coreboot.org

Reply via email to