Hi,

For those who weren't at the meeting today, we're trying to make a few
more changes to code contribution rules to clarify some existing
guidelines and add a new rule about tagging AI-generated contributions
(similar to what we already added for comments). We seemed to have
consensus on these in the meeting already, but if anyone feels
strongly about it this is your chance to object:

1. https://review.coreboot.org/c/coreboot/+/97347

This is about clarifying the Signed-off-by rules to say that you need
to use a name that you can be identified by in real life, not just an
online name like a GitHub account. We changed the requirement from
"real names only" to "established alias/nickname" back in 2023 mostly
because we wanted to avoid discriminating against people who are not
comfortable with using their legal names for whatever reason, but IIRC
it was never about allowing people to just commit code without any
connection to their real-world identity at all. Yet some people have
begun interpreting it that way recently, so it should be clarified.

2. https://review.coreboot.org/c/coreboot/+/97348

There was some ambiguity with the previous AI review policy where we
said "AI shall not respond to comments made by a human", but people
weren't sure whether AI was allowed to just close a comment with
"Done" if it had addressed it in the code. After discussing in the
meeting it sounds like we don't want it to do that, we still want that
to be done explicitly by a human as well, so this patch clarifies the
issue (and reverts the clarification in the other direction that
Martin had submitted previously).

3. https://review.coreboot.org/c/coreboot/+/97349

This patch requires all future contributions where the code was
primarily generated by AI to be tagged as `AI-generated` in the commit
message. This one we left somewhat open in the meeting so I'm happy to
take more feedback here. My idea is that it should be a simple tag
without extra information (e.g. no AI vendor/model info which some
people object to), and it should only be there if the actual code was
primarily written by AI (not just when AI is used in debugging or to
make some vague suggestions). We still disallow any of the other tags
that models like to add on their own, such as `Co-authored-by:
Claude`.
_______________________________________________
coreboot mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to