On 09/07/2010 08:52 AM, Pádraig Brady wrote:
commit e248506b1f664c1602acf76e98e2cafbfe9c5fab Author: Pádraig Brady<[email protected]> Date: Tue Sep 7 15:53:14 2010 +0100tests: work around a failure with dash 0.5.4 * tests/misc/env: Check that the shell can support the operation, before filtering through `env`. diff --git a/tests/misc/env b/tests/misc/env index 5ea01d5..96a4eab 100755 --- a/tests/misc/env +++ b/tests/misc/env @@ -143,8 +143,9 @@ chmod +x c=d || framework_failure test "x`env c=d echo fail`" = xfail || fail=1 test "x`env -- c=d echo fail`" = xfail || fail=1 test "x`env ./c=d echo fail`" = xfail || fail=1 -test "x$(env sh -c '\c=d echo fail')" = xpass || fail=1 test "x$(env sh -c 'exec "$@"' sh c=d echo fail)" = xpass || fail=1 +test "x$(sh -c '\c=d echo fail')" = xpass&& #dash 0.5.4 fails so check first + { test "x$(env sh -c '\c=d echo fail')" = xpass || fail=1; }
Looks good to me. For the record, at least dash 0.5.5.1 no longer has this bug.
-- Eric Blake [email protected] +1-801-349-2682 Libvirt virtualization library http://libvirt.org
