On 29/09/10 07:45, Jim Meyering wrote: > Pádraig Brady wrote: >> +# characters in some locales, triggered abort()s and invalid behavior >> +if test "$(LC_ALL=en_US.ISO-8859-1 locale charmap 2>/dev/null)" = >> ISO-8859-1; >> +then >> + ( > > No big deal, but why run this in a subshell? > It doesn't seem necessary here.
Yes that is overkill in this case. I had copied the sub-shell bit from my locally improved join-i18n test. I've just pushed that. cheers, Pádraig.
