On 01/30/2011 08:40 AM, Jim Meyering wrote:
> FYI, I'm pushing this to the fiemap-copy branch
> that will shortly be pulled to master.
> 
>>From 372479c4afb7f3da2cd72e200a2afe65d718cb42 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <[email protected]>
> Date: Sun, 30 Jan 2011 16:12:56 +0100
> Subject: [PATCH] copy, tee: assume EINTR is always defined: remove #ifdefs
> 
> Don't use "#ifdef EINTR".  dd.c has been doing that since 2004.
> * src/copy.c (sparse_copy): Remove #ifdef...#endif around EINTR use.
> * src/tee.c (tee_files): Remove #ifdef...#endif around EINTR use.
> If we need it, add something like this in system.h:
> /* When EINTR is not defined, define it to an improbable value
>    so that each use does not have to be #ifdef'd.  */

Actually, the gnulib errno module (which we already use) guarantees
pretty much ALL posix-defined errno values.  There's probably other
#ifdef E* that you could scrub.

-- 
Eric Blake   [email protected]    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to